[FEATURE] Macro to detect if a chart has been changed on Runtime #6414
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
None.
Description
This PR introduces a macro that stores the chart text on compile-time to be later used to check if a chart file has been tampered with through mods that use
_mergefolder or override the chart file directly or through overriding a chart through the assets folder, effectively making cheating for scores more difficult.Note that cheated scores are still possible by using some scripts to change the tallies however this PR makes cheating not baby-level.
Also the macro class is inside the
funkin/util/macrofolder so it's inaccessible to scripts.Constants didn't seem to work during compilation so I couldn't use
Constants.DEFAULT_VARIATIONin the macro code, in case you're curious.Screenshots/Videos
True.torial.mp4