[MODDING] Sandboxed FlxSave#6444
Closed
ComedyLost wants to merge 2 commits intoFunkinCrew:developfrom
Closed
Conversation
github-actions
bot
added
status: pending triage
ComedyLost
force-pushed
the
sandboxed-flxsave
branch
from
959e5f6 to
16335cc
Compare
Contributor
|
you finally got it figured out? |
Contributor
Author
Got most of it figured out. Can't figure out how to prevent |
Contributor
|
Can't figure out how to prevent FlxG.save.erase() tho :(
we might need a macro to add `@:unreflective` to `FlxSave.erase`
i'd be willing to contribute that to this PR if you want
|
Contributor
|
remind me to NEVER make a comment with email again |
Contributor
Author
|
If you could, that would be amazing cuz I've been stuck on this for a while and it's the main reason why I never submitted this earlier 😭 |
ComedyLost
force-pushed
the
sandboxed-flxsave
branch
from
0e64cfc to
1b72b45
Compare
Hundrec
force-pushed
the
develop
branch
2 times, most recently
from
3829dcb to
5805c31
Compare
Contributor
Author
|
No longer needed cuz FlxSave is back 👀 |
Hundrec
added
status: rejected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brings back FlxSave (with some restrictions) for modders to use as an alternative to Save.instance.modOptions
Current restrictions
FlxSave.resolveFlixelClasses()