Skip to content

Conversation

@VirtuGuy
Copy link
Contributor

Description

This PR fixes a problem with the latest version of the develop branch where the main menu music refuses to play. This PR solves that issue by moving the line that stops the music to where the previews are cleared when changing a song.

fix.menu.music.not.playing.mp4

@github-actions github-actions bot added size: tiny A tiny pull request with 4 or fewer changes. status: pending triage Awaiting review. pr: haxe PR modifies game code. labels Nov 22, 2025
@Hundrec Hundrec added the type: minor bug Involves a minor bug or issue. label Nov 22, 2025
@AbnormalPoof AbnormalPoof force-pushed the Fix-menu-music-not-playing branch from c6f353c to dcfd8cb Compare November 22, 2025 21:18
@AbnormalPoof AbnormalPoof added status: reviewing internally Under consideration and testing. and removed status: pending triage Awaiting review. labels Nov 22, 2025
Copy link
Member

@AbnormalPoof AbnormalPoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

Copy link
Member

@Hundrec Hundrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aw yeah!

@Hundrec Hundrec changed the base branch from develop to dummy/develop-v0.7.5 November 22, 2025 22:39
@Hundrec Hundrec added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: reviewing internally Under consideration and testing. labels Nov 22, 2025
@Hundrec Hundrec added this to the 0.7.6 milestone Nov 22, 2025
@Hundrec Hundrec merged commit e43ba1d into FunkinCrew:dummy/develop-v0.7.5 Nov 22, 2025
6 checks passed
@VirtuGuy VirtuGuy deleted the Fix-menu-music-not-playing branch November 22, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: haxe PR modifies game code. size: tiny A tiny pull request with 4 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: minor bug Involves a minor bug or issue.

Development

Successfully merging this pull request may close these issues.

3 participants