Fix possible memory leaks and a lot of gc calls from FlxText regenGraphic every frame calls #9
Merged
moondroidcoder merged 1 commit intoFunkinCrew:mobile/mainfrom Dec 24, 2025
Conversation
|
(asking because the title has "possible") does this pr have an actual noticeable effect on performance? |
Member
^ |
Author
I did a couple of tests and no, there is no noticeable change in performance. |
moondroidcoder
approved these changes
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears _borderPixels and graphic in regenGraphic
Yes, i will pull it into OG Flixel, but it here, since funkin/flixel is more accessible