Skip to content

[BUGFIX] Multiple fixes for Week 3 stages #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[BUGFIX] Multiple fixes for Week 3 stages #180

wants to merge 6 commits into from

Conversation

ShadzXD
Copy link
Contributor

@ShadzXD ShadzXD commented May 1, 2025 •
edited
Loading

Does this PR close any issues? If so, link them below.
FunkinCrew/Funkin#3756 & FunkinCrew/Funkin#4373

Briefly describe the issue(s) fixed.

  1. Fixes Train still being on screen when song restarts on both the base phillyTrain stage and the erect variant.
  2. Fixes Train SFX still playing on the results screen, if a train passes by just before the song ends.

Include any relevant screenshots or videos.

2025-05-01.19-54-27.mp4

@ShadzXD ShadzXD changed the title [BUGFIX] Fix Train glitching when song restarts [BUGFIX] Fix Week 3 Train glitching when song restarts May 1, 2025
@ShadzXD ShadzXD changed the title [BUGFIX] Fix Week 3 Train glitching when song restarts [BUGFIX] Fix Week 3 stage Train glitching when song restarts May 1, 2025
@Hundrec Hundrec added type: minor bug Involves a minor bug or issue. status: pending triage Awaiting review. topic: animation editor Related to the operation of the Animation Editor. pr: hscript PR modifies game scripts. labels May 2, 2025
@VioletSnowLeopard
Copy link
Contributor

Unlike in phillyTrain.hx, I noticed that phillyTrainErect.hx doesn't have an onSongEnd function. I believe if you were to copy the onSongEnd function from the non-erect variant into the erect stage, you could fix FunkinCrew/Funkin#4373 as well.

@ShadzXD ShadzXD changed the title [BUGFIX] Fix Week 3 stage Train glitching when song restarts [BUGFIX] Fixes to Week 3 stages May 3, 2025
@ShadzXD ShadzXD changed the title [BUGFIX] Fixes to Week 3 stages [BUGFIX] Multiple fixes for Week 3 stages May 3, 2025
@ShadzXD
Copy link
Contributor Author

ShadzXD commented May 3, 2025

Unlike in phillyTrain.hx, I noticed that phillyTrainErect.hx doesn't have an onSongEnd function. I believe if you were to copy the onSongEnd function from the non-erect variant into the erect stage, you could fix FunkinCrew/Funkin#4373 as well.

fixed!

@Hundrec Hundrec added topic: art and animation Related to visual details and errors in the game. and removed topic: animation editor Related to the operation of the Animation Editor. labels May 4, 2025
@ShadzXD
Update phillyTrain.hxc
8fc9852 
Update phillyTrainErect.hxc
@github-actions github-actions bot added the size: medium A medium pull request with 100 or fewer changes. label May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: hscript PR modifies game scripts. size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. topic: art and animation Related to visual details and errors in the game. type: minor bug Involves a minor bug or issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShadzXD @VioletSnowLeopard @Hundrec