Skip to content

Extend the string analyzers to analyze uses of String.LastIndexOf in … #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2025

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Jun 27, 2025

…the same way it does for String.IndexOf

This is largely copy/pasted from the IndexOf analyzer, with just a few changes to the function names.

refs #21 (comment), where it brings a bit more parity with the simlar analyzers for C#.

…the same way it does for String.IndexOf

This is laregely copy/pasted from the IndexOf analyzer, with just a few changes to the function names.
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Off to a good start here!
Add a changelog entry and ship it?

@Numpsy
Copy link
Contributor Author

Numpsy commented Jun 30, 2025

Changelog updated

@Numpsy Numpsy marked this pull request as ready for review June 30, 2025 14:30
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nojaf nojaf merged commit 2722d80 into G-Research:main Jul 1, 2025
1 check passed
@Numpsy Numpsy deleted the lastindexof branch July 1, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants