-
Notifications
You must be signed in to change notification settings - Fork 0
Replace proto with span serialization #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mladjan-gadzic
merged 21 commits into
main
from
no-ticket-replace-proto-serialization-with-json
May 15, 2025
Merged
Replace proto with span serialization #11
mladjan-gadzic
merged 21 commits into
main
from
no-ticket-replace-proto-serialization-with-json
May 15, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swythan
reviewed
May 12, 2025
swythan
reviewed
May 12, 2025
swythan
reviewed
May 14, 2025
swythan
reviewed
May 14, 2025
G-Research.OpenTelemetry.Processor.Partial/PartialActivityProcessor.cs
Outdated
Show resolved
Hide resolved
swythan
reviewed
May 14, 2025
G-Research.OpenTelemetry.Processor.Partial/PartialActivityProcessor.cs
Outdated
Show resolved
Hide resolved
G-Research.OpenTelemetry.Processor.Partial/PartialActivityProcessor.cs
Outdated
Show resolved
Hide resolved
…essor.cs Co-authored-by: James Chaldecott <[email protected]>
jgiannuzzi
reviewed
May 14, 2025
...penTelemetry.Processor.Partial.Tests/G-Research.OpenTelemetry.Processor.Partial.Tests.csproj
Outdated
Show resolved
Hide resolved
swythan
reviewed
May 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but would be good to fix the compile warnings
G-Research.OpenTelemetry.Processor.Partial/InstrumentationScope.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: James Chaldecott <[email protected]>
Co-authored-by: James Chaldecott <[email protected]>
This reverts commit f2ed582.
swythan
approved these changes
May 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jgiannuzzi
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.