-
Notifications
You must be signed in to change notification settings - Fork 0
Create pipeline for lib release #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
this is based on top of #3 |
# Conflicts: # G-Research.OpenTelemetry.Processor.Partial.Tests/G-Research.OpenTelemetry.Processor.Partial.Tests.csproj # G-Research.OpenTelemetry.Processor.Partial.Tests/PartialActivityProcessorTests.cs # G-Research.OpenTelemetry.Processor.Partial/Example.cs # G-Research.OpenTelemetry.Processor.Partial/G-Research.OpenTelemetry.Processor.Partial.csproj # G-Research.OpenTelemetry.Processor.Partial/PartialActivityProcessor.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 last tiny nitpicks, but otherwise LGTM 👍
G-Research.OpenTelemetry.Processor.Partial/G-Research.OpenTelemetry.Processor.Partial.csproj
Outdated
Show resolved
Hide resolved
This reverts commit 0311975.
Co-authored-by: Jonathan Giannuzzi <[email protected]>
thanks @jgiannuzzi for the effort and reviews :) |
Looks great to me! Thanks @mladjan-gadzic! I think we should fix the warnings and add a nuget readme in a separate PR. Look at the output of |
No description provided.