Skip to content

Create pipeline for lib release #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Apr 29, 2025
Merged

Create pipeline for lib release #4

merged 26 commits into from
Apr 29, 2025

Conversation

mladjan-gadzic
Copy link
Contributor

No description provided.

@mladjan-gadzic
Copy link
Contributor Author

this is based on top of #3

# Conflicts:
#	G-Research.OpenTelemetry.Processor.Partial.Tests/G-Research.OpenTelemetry.Processor.Partial.Tests.csproj
#	G-Research.OpenTelemetry.Processor.Partial.Tests/PartialActivityProcessorTests.cs
#	G-Research.OpenTelemetry.Processor.Partial/Example.cs
#	G-Research.OpenTelemetry.Processor.Partial/G-Research.OpenTelemetry.Processor.Partial.csproj
#	G-Research.OpenTelemetry.Processor.Partial/PartialActivityProcessor.cs
Copy link
Member

@jgiannuzzi jgiannuzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 last tiny nitpicks, but otherwise LGTM 👍

@mladjan-gadzic
Copy link
Contributor Author

thanks @jgiannuzzi for the effort and reviews :)

@jgiannuzzi
Copy link
Member

Looks great to me! Thanks @mladjan-gadzic!

I think we should fix the warnings and add a nuget readme in a separate PR. Look at the output of dotnet package to see what I mean.

@mladjan-gadzic mladjan-gadzic merged commit f2576fe into main Apr 29, 2025
14 checks passed
@mladjan-gadzic mladjan-gadzic deleted the opd-2 branch April 29, 2025 14:27
@mladjan-gadzic mladjan-gadzic linked an issue Apr 29, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create pipeline for lib release
2 participants