Add resource attributes to the LogRecord#26
Merged
jgiannuzzi merged 2 commits intomasterfrom May 14, 2025
Merged
Conversation
- type annotations have also been added where missing - various linter-detected improvements
mladjan-gadzic
approved these changes
May 14, 2025
Contributor
mladjan-gadzic
left a comment
mladjan-gadzic
left a comment
There was a problem hiding this comment.
i did not get any warnings from linter. it might be that i've set it up wrong. thanks for all the improvements! lgtm!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resourceenables setting resource attributes on the partial span log records that are emitted