Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEV] 페이지 title 변경 #53

Merged
merged 2 commits into from
Nov 7, 2024
Merged

[DEV] 페이지 title 변경 #53

merged 2 commits into from
Nov 7, 2024

Conversation

falconlee236
Copy link
Member

Summary

프로그램의 제목을 변경했습니다.

Description

  • 기존 create next app 제목에서 푸앙이 사진관으로 제목을 변경했습니다.
  • 추가적으로 각 페이지마다 제목을 바꿔야 할지, 안그러면 그냥 푸앙이 사진관으로 그대로 둘지 팀원들의 의견이 궁금합니다. 추가 의견이 있다면 comment 남겨주시고 아니면 그냥 approve 해주시면 됩니다.

@falconlee236
Update layout.tsx
d048a45 
 : change title
@falconlee236 falconlee236 added the dev New feature or request label Nov 7, 2024
@falconlee236 falconlee236 added this to the 1.0.0 milestone Nov 7, 2024
@falconlee236 falconlee236 self-assigned this Nov 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Bundle sizes [PuangFilm-FE]

Compared against 16378ed

No significant changes found

@falconlee236 falconlee236 linked an issue Nov 7, 2024 that may be closed by this pull request
[DEV] 페이지 title 변경 #52
Closed
causyj
causyj previously approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@causyj causyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저는 그냥 푸앙이 사진관으로 둬도 괜찮을 것 같습니다
고생이 많으십니다~

@falconlee236
Update Jenkinsfile
4636152 
 : change prune command
@falconlee236
Copy link
Member Author

@causyj 새로 commit을 push하면 기존 approve가 날아가게 설정해서 다시 승인 해주실 수 있나요?

1lsang
1lsang approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@1lsang 1lsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주로 모바일에서 보는 페이지라서 굳이 단계별로 타이틀을 바꿀 필요는 없을 것 같아요!
수고하셨습니다~

@falconlee236 falconlee236 merged commit de0e52b into GDSC-CAU:main Nov 7, 2024
1 check passed
@falconlee236 falconlee236 deleted the dev/change-title branch November 8, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@causyj causyj causyj approved these changes

@1lsang 1lsang 1lsang approved these changes

@ldh019 ldh019 Awaiting requested review from ldh019 ldh019 is a code owner

@yymin1022 yymin1022 Awaiting requested review from yymin1022 yymin1022 is a code owner

Assignees

@falconlee236 falconlee236

Labels
dev New feature or request
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

[DEV] 페이지 title 변경
3 participants
@falconlee236 @1lsang @causyj