[DEV] Android Login UI 구성 및 Firebase Auth 연동 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 26, 2024
|
Ktlint가 좀 많이 엄격한데요.. |
|
컴포저블 소문자 시작은 오케바리로 하겠습니다만, 패키지는 underscore 대신 score를 쓰는게,, 아마 안드로이드 컨벤션이..지.. 싶은데.. |
yymin1022
force-pushed
the
dev/login-activity
branch
from
6d24b87
to
c63fd27
Compare
|
변경된 Ktlint 적용까지 완료되었습니다! |
ldh019
requested changes
Jan 27, 2024
|
|
||
| @AndroidEntryPoint | ||
| class LoginActivity : ComponentActivity() { | ||
| private val viewModel: LoginViewModel by viewModels() |
| import com.gdsc_cau.vridge.R | ||
|
|
||
| @Composable | ||
| fun LoginView(onTryLogin: () -> Unit) { |
There was a problem hiding this comment.
컴포즈에서는 화면을 Screen으로 많이 쓰긴 해요! 한번 잡솨보시는거 어떨까요 하하하
| import dagger.hilt.android.lifecycle.HiltViewModel | ||
| import javax.inject.Inject | ||
|
|
||
| @HiltViewModel |
Comment on lines
+15
to
+17
| @Inject | ||
| constructor() : | ||
| ViewModel() { |
There was a problem hiding this comment.
워닝뜨길래 띄어쓰기 넣어줬지..
| import com.google.firebase.auth.FirebaseUser | ||
| import com.google.firebase.auth.auth | ||
|
|
||
| object FirebaseAuthUtil { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Android 애플리케이션에 LoginActivity UI를 구성하고 Firebase Auth를 연동하였습니다.
Description
Context가 필요한 부분을 Activity 메인 코드와 연동하여 구성하고자 Boolean 형식의LiveData를 활용하였습니다. 또한, Activity 메인 코드에서 구성된ActivityResultLauncher를 파라미터로 전달받아 Google Sign-In 로직 이후 연동해 호출하도록 하였습니다.FirebaseAuthUtil싱글톤클래스(Object)에 작성하였습니다.onCreate생명주기에서 Firebase Auth의getCurrentUser()를 호출하도록 하여 자동로그인이 가능하도록 작성하였습니다.좌 - Light / 우 - Dark
P/S. MVVM 아키텍쳐를 제대로 활용한 것이 맞는지 모르겠읍니다.. 맘에안드는 부분이 있다면 탈탈 털어주십쇼 ㅎㅎ;
그리고 Dark모드 상태에서 NavigationBar 색상 정의를 추가해야할 것 같습니다?