Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routine maintenance/update #49

Merged
merged 4 commits into from
Nov 20, 2023
Merged

Routine maintenance/update #49

merged 4 commits into from
Nov 20, 2023

Conversation

sanAkel
Copy link
Collaborator

@sanAkel sanAkel commented Oct 21, 2023

This PR updates MOM6_GEOSPlug/mom6_cmake/CMakeLists.txt
No change in answers for GEOS.

Contingencies:

To do:

@sanAkel sanAkel added the 0 diff structural Structural changes to repository that are zero-diff label Oct 21, 2023
@sanAkel sanAkel self-assigned this Oct 21, 2023
we need this empty file to avoid hassle!
@sanAkel sanAkel mentioned this pull request Oct 31, 2023
@sanAkel sanAkel marked this pull request as ready for review October 31, 2023 18:09
@sanAkel sanAkel requested review from a team as code owners October 31, 2023 18:09
@sanAkel
Copy link
Collaborator Author

sanAkel commented Oct 31, 2023

@mathomp4 one more request!

Please update GEOS fork of MOM6 when you have a moment. Thank you!

@mathomp4
Copy link
Member

@mathomp4 one more request!

Please update GEOS fork of MOM6 when you have a moment. Thank you!

This has been done. Hopefully if #47 passes its CI, when it's merged, you can update this branch and all will work.

tclune
tclune previously approved these changes Oct 31, 2023
Copy link
Contributor

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMake changes ok.

@sanAkel
Copy link
Collaborator Author

sanAkel commented Nov 16, 2023

@zhaobin74, @yvikhlya can you guys take a look/review this?

@mathomp4 mathomp4 merged commit dd827da into develop Nov 20, 2023
2 of 5 checks passed
@mathomp4 mathomp4 deleted the sanAkel-patch-2 branch November 20, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff structural Structural changes to repository that are zero-diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants