Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use default special member functions for gpx related classes. #586

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

use default special member functions for gpx related classes. #586

wants to merge 4 commits into from

Conversation

tsteven4
Copy link
Collaborator

@tsteven4 tsteven4 commented Jun 2, 2020

also add some missing .h files to the project.

@tsteven4
use default special member functions for gpx related classes.
2c5bd59 
also add some missing .h files to the project.
GPSBabelDeveloper
GPSBabelDeveloper approved these changes Jun 3, 2020
View reviewed changes
Copy link
Collaborator

@GPSBabelDeveloper GPSBabelDeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could length and elevation be std::optionals instead of out-of-bound values?

Either is ok. This is a good enough of this code.

@tsteven4
Copy link
Collaborator Author

tsteven4 commented Jun 3, 2020

std::optional is c++17. We get away with it in the CLI because we emulate it in src/core/optional.h.

@tsteven4 Codacy Production
Copy link
Collaborator Author

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
           

Clones added
============
- gui/gmapdlg.cc  3

See the complete overview on Codacy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GPSBabelDeveloper GPSBabelDeveloper GPSBabelDeveloper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsteven4 @GPSBabelDeveloper