Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promotion from AMD internal branch for 2024.Q3.1 #2903

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Promotion from AMD internal branch for 2024.Q3.1 #2903

merged 1 commit into from
Aug 13, 2024

Conversation

qiaojbao
Copy link
Collaborator

@qiaojbao qiaojbao commented Aug 8, 2024

[Continuations] Remove CONTINUATIONS_USE_DUMMY_RET_ADDR define [Continuations] Remove references to _cont_SetupRayGen [RT] Fix IR verifier error when reading GPURT
SPIRVReader: Add LayoutMode::None, remove isParentPointer, m_typeMap, make recordTypeWithPad return void [LGC] Remove descriptor type argument from getDescPtr Fix broken spvasm tests
Add support for SPV_EXT_fragment_shader_interlock
compilerutils: Put TypeLowering into a namespace
Remove RT lit test dependency on SPIR-V binary
Fix and cleanup barrier translation
Add an check of dual source blend in full pipeline [LGC] Fix deprecation warnings
SPIRVReader: Unify OpType{Runtime}Array conversion Fix OpControlBarrier mapping
Fix compiling warning of switch cases
[LGC] Handle load and build buffer descriptor in PatchBufferOp SPIRVReader: refactor image support
[Continuations] Pass padding and payload as argument [Continuations] Fix irreducible cycle during continuation transform Unify the namespace compilerutils with CompilerUtils Rework mesh shader export slot assignment
[Continuations] Remove RegisterBuffer pass.
[RT] Rayquery refactor to lgc
[LGC] Fix cast error when forceRawView buffer load is used [Continuations] Remove DISABLE_CPS_PAYLOADREG define. Stop replacing atomicrmw fadd instructions with intrinsics [LGC] Missing index for LoadTfeOp structured load
[Continations] Remove comment on register buffer
Remove assertion and update tests to align with recent LLVM changes amdllpc: Fix amdllpc test failure PipelineRays_TestStaticCompile.pipe [Continuations] Move handleGetFuncAddr
amdllpc: Flush SPIR-V output to aid in debugging
Make readlane call mangling-agnostic
[LGC] Fix deprecated StringRef::equals warning
[LGC] Remove use of RepeatedPass
[LGC] Include FormatVariadic.h
[Continuations] Reformat code
SPIRVReader: workaround for some invalid SPIR-V
Fix traversal module pop back
Extract LowerRayQuery from LGC and move to RT
[Continuations] Dialectify continuation.continue and continuation.waitContinue. Update intrinsic names for upstream change
Fix use-after-free in LowerRayQuery refactor
Add debug printer for ModuleBunch
Stop replacing atomicrmw fmin/fmax instructions with intrinsics Update tests for non-i8 gep of mul change
[Continuations] Tidy up assertion in LowerRaytracingPipeline Prefer mdconst::extract over mdconst::dyn_extract
Update includes and fwd decls
Fix some Clang warnings
Enable intrinsic instead of using named call
Use range-based set() for SmallBitVector
[LGC] Add dereferenceable info for descriptor load [Continuations] Ignore single unreachable in block [CompilerUtils] Handle phi in replaceAllPointerUses Use CreateIntrinsic for building intrinsic calls
llvmraytracing: Add getShaderSubtypeForRtShaderStage [Continuations] Refactor metadata handling
[RT] Support GpurtGetKnown(Un)SetRayFlagsOp, and add a lit test Fix build and test issue when bumping LLPC version to 73 Move the Dx9MulZero match from llpcSpirvLowerMath into PatchMulDx9Zero which is added after Scalarize Pass llvmraytracing: Add getFuncReturnPtrElementType
[RT] Avoid unnecessary compilations for traversal module Fix RTIP-overriding for GPURT rayQuery functions
Fix #include file ordering
[LGC] Set new .uses_cps PAL metadata where applicable [CompilerUtils] Simplify pointee types metadata
[Continuations] Use lgc.cps.jump in LegacyCleanupContinuations [CompilerUtils] Move promotePointerArguments etc to compilerutils Use function linkage setting from spirv
[CompilerUtils] Fix cross-module-inliner tests, and move to subdir [LGC] Add option to force user data spilling
Improve continuations heuristic
[Continuations] Fix clang-format
Remove SpirvLowerRayQuery from lower passes
[Continuations] Cleanup continuations analyses, remove registercount + statesize metadata [Continuations] Prevent zero-size lgc.cps.free calls in CleanupContinuations [LGC] Replace threadMaskedSelect function to use inverseballot [LGC] Only insert non null components in reassembleOutputExportCalls [Continuations] Use new replaceVarArgs helper from dialects [Continuations] Add constant jump 'inliner' pass
[Continuations] Basic Continuations 'linter' pass
[Continuations] Introduce lgc.cps.jump in LowerRaytracingPipeline Remove explicit LLVM benchmark targets from CMake
[Continuations] Handle _AmdValue* intrinsics
[LGC] Fix issues of FS without exports
Fix dEQP-VK.subgroups.arithmetic.ray_tracing* crash Update llvm-dialects submodule
Pack mesh shader outputs in LDS space

@qiaojbao qiaojbao requested a review from a team as a code owner August 8, 2024 09:14
[Continuations] Remove `CONTINUATIONS_USE_DUMMY_RET_ADDR` define
[Continuations] Remove references to `_cont_SetupRayGen`
[RT] Fix IR verifier error when reading GPURT
SPIRVReader: Add LayoutMode::None, remove isParentPointer, m_typeMap, make recordTypeWithPad return void
[LGC] Remove descriptor type argument from getDescPtr
Fix broken spvasm tests
Add support for SPV_EXT_fragment_shader_interlock
compilerutils: Put TypeLowering into a namespace
Remove RT lit test dependency on SPIR-V binary
Fix and cleanup barrier translation
Add an check of dual source blend in full pipeline
[LGC] Fix deprecation warnings
SPIRVReader: Unify OpType{Runtime}Array conversion
Fix OpControlBarrier mapping
Fix compiling warning of switch cases
[LGC] Handle load and build buffer descriptor in PatchBufferOp
SPIRVReader: refactor image support
[Continuations] Pass padding and payload as argument
[Continuations] Fix irreducible cycle during continuation transform
Unify the namespace compilerutils with CompilerUtils
Rework mesh shader export slot assignment
[Continuations] Remove RegisterBuffer pass.
[RT] Rayquery refactor to lgc
[LGC] Fix cast error when forceRawView buffer load is used
[Continuations] Remove `DISABLE_CPS_PAYLOADREG` define.
Stop replacing atomicrmw fadd instructions with intrinsics
[LGC] Missing index for LoadTfeOp structured load
[Continations] Remove comment on register buffer
Remove assertion and update tests to align with recent LLVM changes
amdllpc: Fix amdllpc test failure PipelineRays_TestStaticCompile.pipe
[Continuations] Move `handleGetFuncAddr`
amdllpc: Flush SPIR-V output to aid in debugging
Make readlane call mangling-agnostic
[LGC] Fix deprecated StringRef::equals warning
[LGC] Remove use of RepeatedPass
[LGC] Include FormatVariadic.h
[Continuations] Reformat code
SPIRVReader: workaround for some invalid SPIR-V
Fix traversal module pop back
Extract LowerRayQuery from LGC and move to RT
[Continuations] Dialectify `continuation.continue` and `continuation.waitContinue`.
Update intrinsic names for upstream change
Fix use-after-free in LowerRayQuery refactor
Add debug printer for ModuleBunch
Stop replacing atomicrmw fmin/fmax instructions with intrinsics
Update tests for non-i8 gep of mul change
[Continuations] Tidy up assertion in LowerRaytracingPipeline
Prefer mdconst::extract over mdconst::dyn_extract
Update includes and fwd decls
Fix some Clang warnings
Enable intrinsic instead of using named call
Use range-based set() for SmallBitVector
[LGC] Add dereferenceable info for descriptor load
[Continuations] Ignore single unreachable in block
[CompilerUtils] Handle phi in replaceAllPointerUses
Use CreateIntrinsic for building intrinsic calls
llvmraytracing: Add getShaderSubtypeForRtShaderStage
[Continuations] Refactor metadata handling
[RT] Support GpurtGetKnown(Un)SetRayFlagsOp, and add a lit test
Fix build and test issue when bumping LLPC version to 73
Move the Dx9MulZero match from llpcSpirvLowerMath into PatchMulDx9Zero which is added after Scalarize Pass
llvmraytracing: Add getFuncReturnPtrElementType
[RT] Avoid unnecessary compilations for traversal module
Fix RTIP-overriding for GPURT rayQuery functions
Fix #include file ordering
[LGC] Set new .uses_cps PAL metadata where applicable
[CompilerUtils] Simplify pointee types metadata
[Continuations] Use `lgc.cps.jump` in `LegacyCleanupContinuations`
[CompilerUtils] Move promotePointerArguments etc to compilerutils
Use function linkage setting from spirv
[CompilerUtils] Fix cross-module-inliner tests, and move to subdir
[LGC] Add option to force user data spilling
Improve continuations heuristic
[Continuations] Fix clang-format
Remove SpirvLowerRayQuery from lower passes
[Continuations] Cleanup continuations analyses, remove registercount + statesize metadata
[Continuations] Prevent zero-size `lgc.cps.free` calls in `CleanupContinuations`
[LGC] Only insert non null components in reassembleOutputExportCalls
[Continuations] Use new `replaceVarArgs` helper from dialects
[Continuations] Add constant jump 'inliner' pass
[Continuations] Basic Continuations 'linter' pass
[Continuations] Introduce lgc.cps.jump in `LowerRaytracingPipeline`
Remove explicit LLVM benchmark targets from CMake
[Continuations] Handle _AmdValue* intrinsics
[LGC] Fix issues of FS without exports
Update llvm-dialects submodule
Pack mesh shader outputs in LDS space
@amdvlk-admin
Copy link

Test summary for commit 5278a3f

CTS tests (Failed: 11/148731)
  • Built with version 1.3.5.2.RC
  • Ubuntu navi3x, Srdcvk
    • Passed: 35588/75073 (47.4%)
    • Failed: 0/75073 (0.0%)
    • Not Supported: 39485/75073 (52.6%)
    • Warnings: 0/75073 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 34685/73658 (47.1%)
    • Failed: 11/73658 (0.0%)

      Failures:

      FAILURE: dEQP-VK.api.object_management.alloc_callback_fail.device_group
      Stack trace: Crash
      
      FAILURE: dEQP-VK.api.object_management.max_concurrent.device_group
      Stack trace: Crash
      
      FAILURE: dEQP-VK.api.object_management.multiple_shared_resources.device_group
      Stack trace: Crash
      
      FAILURE: dEQP-VK.api.object_management.multiple_unique_resources.device_group
      Stack trace: Crash
      
      FAILURE: dEQP-VK.api.object_management.multithreaded_per_thread_resources.device_group
      Stack trace: Crash
      
      FAILURE: dEQP-VK.api.object_management.multithreaded_shared_resources.device_group
      Stack trace: Crash
      
      FAILURE: dEQP-VK.api.object_management.single.device_group
      Stack trace: Crash
      
      FAILURE: dEQP-VK.api.object_management.single_alloc_callbacks.device_group
      Stack trace: Crash
      
      FAILURE: dEQP-VK.device_group.sfr
      Stack trace: Crash
      
      FAILURE: dEQP-VK.device_group.sfr_dedicated
      Stack trace: Flake
      
      FAILURE: dEQP-VK.device_group.sfr_sys
      Stack trace: Crash
      

    • Not Supported: 38962/73658 (52.9%)
    • Warnings: 0/73658 (0.0%)

@qiaojbao
Copy link
Collaborator Author

test this please

@amdvlk-admin
Copy link

Test summary for commit 5278a3f

CTS tests (Failed: 11/148731)
  • Built with version 1.3.5.2.RC
  • Ubuntu navi3x, Srdcvk
    • Passed: 35588/75073 (47.4%)
    • Failed: 0/75073 (0.0%)
    • Not Supported: 39485/75073 (52.6%)
    • Warnings: 0/75073 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 34685/73658 (47.1%)
    • Failed: 11/73658 (0.0%)

      Failures:

      FAILURE: dEQP-VK.api.object_management.alloc_callback_fail.device_group
      Stack trace: Crash
      
      FAILURE: dEQP-VK.api.object_management.max_concurrent.device_group
      Stack trace: Crash
      
      FAILURE: dEQP-VK.api.object_management.multiple_shared_resources.device_group
      Stack trace: Crash
      
      FAILURE: dEQP-VK.api.object_management.multiple_unique_resources.device_group
      Stack trace: Crash
      
      FAILURE: dEQP-VK.api.object_management.multithreaded_per_thread_resources.device_group
      Stack trace: Crash
      
      FAILURE: dEQP-VK.api.object_management.multithreaded_shared_resources.device_group
      Stack trace: Crash
      
      FAILURE: dEQP-VK.api.object_management.single.device_group
      Stack trace: Crash
      
      FAILURE: dEQP-VK.api.object_management.single_alloc_callbacks.device_group
      Stack trace: Crash
      
      FAILURE: dEQP-VK.device_group.sfr
      Stack trace: Crash
      
      FAILURE: dEQP-VK.device_group.sfr_dedicated
      Stack trace: Flake
      
      FAILURE: dEQP-VK.device_group.sfr_sys
      Stack trace: Crash
      

    • Not Supported: 38962/73658 (52.9%)
    • Warnings: 0/73658 (0.0%)

@amdvlk-admin
Copy link

Test summary for commit 5278a3f

CTS tests (Failed: 0/148731)
  • Built with version 1.3.5.2.RC
  • Ubuntu navi3x, Srdcvk
    • Passed: 35588/75073 (47.4%)
    • Failed: 0/75073 (0.0%)
    • Not Supported: 39485/75073 (52.6%)
    • Warnings: 0/75073 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 34693/73658 (47.1%)
    • Failed: 0/73658 (0.0%)
    • Not Supported: 38965/73658 (52.9%)
    • Warnings: 0/73658 (0.0%)

@qiaojbao qiaojbao merged commit 5278a3f into dev Aug 13, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants