Fix RPSL explorer compilation not working on Windows#29
Open
Mcgode wants to merge 2 commits intoGPUOpen-LibrariesAndSDKs:mainfrom
Open
Fix RPSL explorer compilation not working on Windows#29Mcgode wants to merge 2 commits intoGPUOpen-LibrariesAndSDKs:mainfrom
Mcgode wants to merge 2 commits intoGPUOpen-LibrariesAndSDKs:mainfrom
Conversation
|
I think using the |
Author
|
Indeed, thanks for the comment. The RPS lib itself target C++11 but |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RPSL compilation command does not work on Windows, and seems to have been designed for Unix-like systems.
This PR fixes the command line for Windows, while keeping compatibility with Unix systems.
Addresses #28