Merge pull request #4426 from GSA-TTS/main

GSA-TTS · Nov 1, 2024 · cef536d · cef536d
2 parents f338ea6 + 8973e32
commit cef536d
Show file tree

Hide file tree

Showing 3 changed files with 46 additions and 36 deletions.
diff --git a/backend/audit/views/manage_submission_access.py b/backend/audit/views/manage_submission_access.py
@@ -206,9 +206,9 @@ def get(self, request, *args, **kwargs):
         report_id = kwargs["report_id"]
         sac = SingleAuditChecklist.objects.get(report_id=report_id)
 
-        try:
-            Access.objects.get(email=request.user.email, sac=sac, role=self.role)
-        except Access.DoesNotExist:
+        if not Access.objects.filter(
+            email=request.user.email, sac=sac, role=self.role
+        ).exists():
             raise PermissionDenied(
                 "Only Audit Editors may remove audit access for other Audit Editors."
             )
@@ -240,9 +240,9 @@ def post(self, request, *args, **kwargs):
         report_id = kwargs["report_id"]
         sac = SingleAuditChecklist.objects.get(report_id=report_id)
 
-        try:
-            Access.objects.get(email=request.user.email, sac=sac, role=self.role)
-        except Access.DoesNotExist:
+        if not Access.objects.filter(
+            email=request.user.email, sac=sac, role=self.role
+        ).exists():
             raise PermissionDenied(
                 "Only Audit Editors may remove audit access for other Audit Editors."
             )

diff --git a/backend/package-lock.json b/backend/package-lock.json
diff --git a/backend/package.json b/backend/package.json
@@ -24,16 +24,16 @@
   "license": "ISC",
   "devDependencies": {
     "@4tw/cypress-drag-drop": "^2.2.5",
-    "@babel/eslint-parser": "^7.25.8",
-    "@eslint/js": "^9.12.0",
-    "cypress": "^13.15.0",
+    "@babel/eslint-parser": "^7.25.9",
+    "@eslint/js": "^9.13.0",
+    "cypress": "^13.15.1",
     "cypress-axe": "^1.5.0",
     "cypress-downloadfile": "^1.2.4",
     "cypress-file-upload": "^5.0.8",
     "cypress-otp": "^1.0.3",
-    "eslint": "^9.12.0",
+    "eslint": "^9.13.0",
     "eslint-config-prettier": "^9.1.0",
-    "eslint-plugin-cypress": "^4.0.0",
+    "eslint-plugin-cypress": "^4.1.0",
     "eslint-plugin-prettier": "^5.2.1",
     "prettier": "^3.3.3",
     "stylelint": "^15.10.1",