Skip to content

Commit cef536d

Browse files
author
Matthew Jadud
authored
Merge pull request #4426 from GSA-TTS/main
2 parents f338ea6 + 8973e32 commit cef536d

File tree

3 files changed

+46
-36
lines changed

3 files changed

+46
-36
lines changed

backend/audit/views/manage_submission_access.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -206,9 +206,9 @@ def get(self, request, *args, **kwargs):
206206
report_id = kwargs["report_id"]
207207
sac = SingleAuditChecklist.objects.get(report_id=report_id)
208208

209-
try:
210-
Access.objects.get(email=request.user.email, sac=sac, role=self.role)
211-
except Access.DoesNotExist:
209+
if not Access.objects.filter(
210+
email=request.user.email, sac=sac, role=self.role
211+
).exists():
212212
raise PermissionDenied(
213213
"Only Audit Editors may remove audit access for other Audit Editors."
214214
)
@@ -240,9 +240,9 @@ def post(self, request, *args, **kwargs):
240240
report_id = kwargs["report_id"]
241241
sac = SingleAuditChecklist.objects.get(report_id=report_id)
242242

243-
try:
244-
Access.objects.get(email=request.user.email, sac=sac, role=self.role)
245-
except Access.DoesNotExist:
243+
if not Access.objects.filter(
244+
email=request.user.email, sac=sac, role=self.role
245+
).exists():
246246
raise PermissionDenied(
247247
"Only Audit Editors may remove audit access for other Audit Editors."
248248
)

backend/package-lock.json

Lines changed: 35 additions & 25 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

backend/package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,16 +24,16 @@
2424
"license": "ISC",
2525
"devDependencies": {
2626
"@4tw/cypress-drag-drop": "^2.2.5",
27-
"@babel/eslint-parser": "^7.25.8",
28-
"@eslint/js": "^9.12.0",
29-
"cypress": "^13.15.0",
27+
"@babel/eslint-parser": "^7.25.9",
28+
"@eslint/js": "^9.13.0",
29+
"cypress": "^13.15.1",
3030
"cypress-axe": "^1.5.0",
3131
"cypress-downloadfile": "^1.2.4",
3232
"cypress-file-upload": "^5.0.8",
3333
"cypress-otp": "^1.0.3",
34-
"eslint": "^9.12.0",
34+
"eslint": "^9.13.0",
3535
"eslint-config-prettier": "^9.1.0",
36-
"eslint-plugin-cypress": "^4.0.0",
36+
"eslint-plugin-cypress": "^4.1.0",
3737
"eslint-plugin-prettier": "^5.2.1",
3838
"prettier": "^3.3.3",
3939
"stylelint": "^15.10.1",

0 commit comments

Comments
 (0)