Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-11857: add header post office search results #1391

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

KeithNava
Copy link
Contributor

@KeithNava KeithNava commented Nov 13, 2024

🎫 Ticket

Link to the relevant ticket.
11857

🛠 Summary of changes

Utilized a new prop in the FullAddressSearch component to display a header on top of the post office search results

📜 Testing Plan

  • Start up the application and navigate to the post office search page
  • Run the search
  • Notice the new header Search results for Post Offices near you that does not exist in main / any higher environment

📸 Screenshots

English

help-center-PO-Search-heading--en

Spanish

help-center-PO-Search-heading--es

French

help-center-PO-Search-heading--fr

Chinese

help-center-PO-Search-heading--zh

@KeithNava KeithNava marked this pull request as ready for review November 14, 2024 15:07
@WilliamBirdsall
Copy link

Looks good but why did we up the package minor version by 2 instead of 1?

@KeithNava
Copy link
Contributor Author

Looks good but why did we up the package minor version by 2 instead of 1?

@WilliamBirdsall thanks for noticing that! Yea we actually did have a version in between that doesn't contain the changes I made in the package https://github.com/18F/identity-idp/pull/11424/files#diff-9379660924562952dd49545a0ef39b5a131d578e2a592e7db0c5a5bb18fccb2fR3

@eileen-nava
Copy link

Hi @KeithNava, when including screenshots in a PR description, could you please use the table format that autopopulates in the repo's PR template? That will make the screenshots smaller and more manageable to review. If you'd like to see an example of the table format being used, Andrew's recent PR, PR #1387, is a good example. Thanks!

Copy link

@eileen-nava eileen-nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally and everything worked well. Good work. 👍🏻 I left a question about tags.

@gina-yamada
Copy link
Contributor

gina-yamada commented Nov 15, 2024

I tested this locally. I can see the header in all languages the Help Center.

local testing in Help Center- screenshot in English

Screenshot 2024-11-15 at 2 35 18 PM

@gina-yamada gina-yamada self-requested a review November 15, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants