-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG-11857: add header post office search results #1391
base: main
Are you sure you want to change the base?
LG-11857: add header post office search results #1391
Conversation
Looks good but why did we up the package minor version by 2 instead of 1? |
@WilliamBirdsall thanks for noticing that! Yea we actually did have a version in between that doesn't contain the changes I made in the package https://github.com/18F/identity-idp/pull/11424/files#diff-9379660924562952dd49545a0ef39b5a131d578e2a592e7db0c5a5bb18fccb2fR3 |
Hi @KeithNava, when including screenshots in a PR description, could you please use the table format that autopopulates in the repo's PR template? That will make the screenshots smaller and more manageable to review. If you'd like to see an example of the table format being used, Andrew's recent PR, PR #1387, is a good example. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested locally and everything worked well. Good work. 👍🏻 I left a question about tags.
🎫 Ticket
Link to the relevant ticket.
11857
🛠 Summary of changes
Utilized a new prop in the
FullAddressSearch
component to display a header on top of the post office search results📜 Testing Plan
Search results for Post Offices near you
that does not exist in main / any higher environment📸 Screenshots
English
Spanish
French
Chinese