-
Notifications
You must be signed in to change notification settings - Fork 117
Add Latest Example SSP Changes #1162
Add Latest Example SSP Changes #1162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we going to adjust the link[@rel="proof-of-compliance"]
references to match the approach in the other PRs? I am running validation locally without external constraint files and the indices are failing.
Is this also just a refresh or is there more context I am missing? I think I understood from Google Chat, but just want to confirm. (Let's update that checklist. :wink)
I just grabbed the latest version of the example SSP and opened a PR to run tests and see all the errors. This is not in a final state. We need to iron out all of the errors |
So we want to merge it ASAP or is it a work in progress then? |
0230263
to
bcedb8d
Compare
c78bf63
to
9914d24
Compare
Apologies for just noticing this comment, but the goal is to merge it ASAP. |
Nice work on the PR @Gabeblis. I was able to validate locally, and once the upstream changes are made, we'll be able to uncomment and things should work fine. Minor style feedback: We had started to use "mock" UUIDs throughout the examples and documentations to make it easier for our audience to follow (see https://github.com/GSA/fedramp-automation/blob/dd4871a1e86482411567068f5c0e0a4afb0eae41/src/content/rev5/examples/UUIDs_for_Examples_Legend.md). This brings up a few questions:
|
|
My take on this is that we do not really need the headache of documenting it yet unless we think it will add value for downstream developers, and that is pretty involved inside baseball at this time. That said, I am willing to discuss tomorrow morning why you are pitching publication of it, because if we commit to it, maintenance will be fun. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Iam not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs a rebase |
ada10ea
9914d24
to
ada10ea
Compare
ada10ea
to
2f63c65
Compare
3de8d1a
to
991be34
Compare
Committer Notes
Purpose
This PR aims to update our example SSP with the latest content from Brian's Example SSP Branch.
All Submissions:
- [ ] If applicable, have all FedRAMP Documents Related to OSCAL Adoption affected by the changes in this issue have been updated.?Not applicable.By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.