Feature/canary constraints

[wandmagic]

Committer Notes

add constraints that were missing from canary

All Submissions:

• Have you selected the correct base branch per Contributing guidance?
• Have you set "Allow edits and access to secrets by maintainers"?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Have you squashed any non-relevant commits and commit messages? [instructions]
• Have you added an explanation of what your changes do and why you'd like us to include them?
• If applicable, have all FedRAMP Documents Related to OSCAL Adoption affected by the changes in this issue have been updated.?
• If applicable, does this PR reference the issue it addresses and explain how it addresses the issue?

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

[aj-stein-gsa]

Thanks for the rebase, @wandmagic, I will look in a bit.

[aj-stein-gsa]

Is there a reason on /system-security-plan/system-implementation[1]/inventory-item[1] we are not adding back in the necessary prop[@name="software-name"] and for /system-security-plan/system-implementation[1]/inventory-item[4] the inventory item prop[@name="function"], @wandmagic? I might just push up and bull this in to get it over with.

[wandmagic]

Is there a reason on /system-security-plan/system-implementation[1]/inventory-item[1] we are not adding back in the necessary prop[@name="software-name"] and for /system-security-plan/system-implementation[1]/inventory-item[4] the inventory item prop[@name="function"], @wandmagic? I might just push up and bull this in to get it over with.

the canary and develop got pretty out of sync, but i think we now have the missing constraints passing, so we should be good, thanks for your help!

[aj-stein-gsa]

the canary and develop got pretty out of sync, but i think we now have the missing constraints passing, so we should be good, thanks for your help!

Ha, well I was like "no they aren't" and I see you picked up where I left off before sleepy time. Nice work!

[wandmagic]

the canary and develop got pretty out of sync, but i think we now have the missing constraints passing, so we should be good, thanks for your help!

Ha, well I was like "no they aren't" and I see you picked up where I left off before sleepy time. Nice work!

Teamwork makes the dreamwork