-
Notifications
You must be signed in to change notification settings - Fork 117
Add Control Origination Allowed Values #1213
Conversation
5b9c4d9
to
accc629
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gabeblis, requesting monior change to align constraint ID. Otherwise, all looks good.
accc629
to
a519691
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I owe you improved acceptance criteria. Apologies in advance, but the changes will be minor. 🤦
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sorry to do this but please check the much delayed update to the AC and constraint requirements I corrected a few minutes ago. Please also observe there can be multiple occurrences of the prop.
Again, thanks again for humoring the last few days of blatant errors in issue requirements. Let me know if you have additional questions. The error is completely on my side, this work was very solid, if only someone did requirements correctly. 😆
a519691
to
feb5548
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!!
Committer Notes
Purpose
This PR aims to add a
Control Origination
Allowed Values
constraint that verifies that the control origination of an implemented requirement aligns with one the FedRAMP designated allowed values.Changes
frr306
andfrr307
constraints.All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.