Skip to content
This repository was archived by the owner on Jul 1, 2025. It is now read-only.

Add Control Origination Allowed Values #1213

Merged
merged 3 commits into from
Mar 25, 2025

Conversation

Gabeblis
Copy link
Contributor

@Gabeblis Gabeblis commented Mar 18, 2025

Committer Notes

Purpose

This PR aims to add a Control Origination Allowed Values constraint that verifies that the control origination of an implemented requirement aligns with one the FedRAMP designated allowed values.

Changes

  • Added frr306 and frr307 constraints.
  • Added associated negative test data.
  • Added associated pass/fail YAML files.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis self-assigned this Mar 18, 2025
@Gabeblis Gabeblis requested a review from a team as a code owner March 18, 2025 13:39
@Gabeblis Gabeblis linked an issue Mar 18, 2025 that may be closed by this pull request
16 tasks
@Gabeblis Gabeblis force-pushed the constraints/issue-868 branch from 5b9c4d9 to accc629 Compare March 18, 2025 15:26
Copy link

@Rene2mt Rene2mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gabeblis, requesting monior change to align constraint ID. Otherwise, all looks good.

@Gabeblis Gabeblis force-pushed the constraints/issue-868 branch from accc629 to a519691 Compare March 19, 2025 14:17
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I owe you improved acceptance criteria. Apologies in advance, but the changes will be minor. 🤦

Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry to do this but please check the much delayed update to the AC and constraint requirements I corrected a few minutes ago. Please also observe there can be multiple occurrences of the prop.

#868 (comment)

Again, thanks again for humoring the last few days of blatant errors in issue requirements. Let me know if you have additional questions. The error is completely on my side, this work was very solid, if only someone did requirements correctly. 😆

@Gabeblis Gabeblis force-pushed the constraints/issue-868 branch from a519691 to feb5548 Compare March 21, 2025 05:08
aj-stein-gsa
aj-stein-gsa previously approved these changes Mar 21, 2025
Copy link

@Rene2mt Rene2mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!!

@aj-stein-gsa aj-stein-gsa merged commit 0a3b977 into GSA:develop Mar 25, 2025
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for control-origination in SSP
3 participants