Skip to content

Commit

Permalink
refactor: remove the "photo" plugin
Browse files Browse the repository at this point in the history 
This plugin was deprecated and removed in all clients.

See also: https://bugs.kde.org/show_bug.cgi?id=474121
  • Loading branch information
@andyholmes
andyholmes committed Sep 25, 2023
1 parent 522181d commit f077766
Show file tree
Hide file tree
Showing 8 changed files with 1 addition and 404 deletions.
10 changes: 1 addition & 9 deletions data/org.gnome.Shell.Extensions.GSConnect.gschema.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ SPDX-License-Identifier: GPL-2.0-or-later
<default>{}</default>
</key>
<key name="menu-actions" type="as">
<default>["sms", "ring", "mount", "commands", "share", "photo", "keyboard"]</default>
<default>["sms", "ring", "mount", "commands", "share", "keyboard"]</default>
</key>
<key name="name" type="s">
<default>""</default>
Expand Down Expand Up @@ -141,14 +141,6 @@ SPDX-License-Identifier: GPL-2.0-or-later
<default>'{}'</default>
</key>
</schema>
<schema id="org.gnome.Shell.Extensions.GSConnect.Plugin.Photo">
<key name="share-camera" type="b">
<default>true</default>
</key>
<key name="receive-directory" type="s">
<default>""</default>
</key>
</schema>
<schema id="org.gnome.Shell.Extensions.GSConnect.Plugin.Ping"/>
<schema id="org.gnome.Shell.Extensions.GSConnect.Plugin.Presenter"/>
<schema id="org.gnome.Shell.Extensions.GSConnect.Plugin.RunCommand">
Expand Down
57 changes: 0 additions & 57 deletions data/ui/preferences-device-panel.ui
View file
Original file line number Diff line number Diff line change
Expand Up @@ -78,63 +78,6 @@ SPDX-License-Identifier: GPL-2.0-or-later
<property name="selection_mode">none</property>
<signal name="row-activated" handler="_onToggleRowActivated" swapped="no"/>
<signal name="keynav-failed" handler="_onKeynavFailed" swapped="no"/>
<child>
<object class="GtkListBoxRow" id="photo">
<property name="height_request">56</property>
<property name="visible">True</property>
<property name="can_focus">True</property>
<property name="selectable">False</property>
<child>
<object class="GtkGrid">
<property name="visible">True</property>
<property name="can_focus">False</property>
<property name="margin_start">12</property>
<property name="margin_end">12</property>
<property name="column_spacing">12</property>
<child>
<object class="GtkLabel" id="share-photo-label">
<property name="visible">True</property>
<property name="can_focus">False</property>
<property name="halign">start</property>
<property name="valign">center</property>
<property name="hexpand">True</property>
<property name="vexpand">True</property>
<property name="label" translatable="yes">Camera</property>
<accessibility>
<relation type="label-for" target="photo"/>
<relation type="label-for" target="share-photo"/>
</accessibility>
</object>
<packing>
<property name="left_attach">0</property>
<property name="top_attach">0</property>
</packing>
</child>
<child>
<object class="GtkSwitch" id="share-photo">
<property name="visible">True</property>
<property name="can_focus">True</property>
<property name="halign">end</property>
<property name="valign">center</property>
<property name="action_name">settings.share-camera</property>
<accessibility>
<relation type="controlled-by" target="photo"/>
<relation type="labelled-by" target="share-photo-label"/>
</accessibility>
</object>
<packing>
<property name="left_attach">1</property>
<property name="top_attach">0</property>
</packing>
</child>
</object>
</child>
<accessibility>
<relation type="controller-for" target="share-photo"/>
<relation type="labelled-by" target="share-photo-label"/>
</accessibility>
</object>
</child>
<child>
<object class="GtkListBoxRow" id="clipboard">
<property name="height_request">56</property>
Expand Down
1 change: 0 additions & 1 deletion installed-tests/suites/plugins/meson.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ plugin_tests = [
'MousepadPlugin',
'MprisPlugin',
'NotificationPlugin',
'PhotoPlugin',
'PingPlugin',
'PresenterPlugin',
'RuncommandPlugin',
Expand Down
85 changes: 0 additions & 85 deletions installed-tests/suites/plugins/testPhotoPlugin.js
View file

This file was deleted.

1 change: 0 additions & 1 deletion po/POTFILES
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ src/service/plugins/findmyphone.js
src/service/plugins/mousepad.js
src/service/plugins/mpris.js
src/service/plugins/notification.js
src/service/plugins/photo.js
src/service/plugins/ping.js
src/service/plugins/presenter.js
src/service/plugins/runcommand.js
Expand Down
3 changes: 0 additions & 3 deletions src/preferences/device.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -463,9 +463,6 @@ var Panel = GObject.registerClass({
this.actions.add_action(settings.create_action('send-notifications'));
this.actions.add_action(settings.create_action('send-active'));

settings = this.pluginSettings('photo');
this.actions.add_action(settings.create_action('share-camera'));

settings = this.pluginSettings('sftp');
this.actions.add_action(settings.create_action('automount'));

Expand Down
12 changes: 0 additions & 12 deletions src/service/daemon.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -468,15 +468,6 @@ const Service = GObject.registerClass({
'<id>'
);

this.add_main_option(
'photo',
0,
GLib.OptionFlags.NONE,
GLib.OptionArg.NONE,
_('Photo'),
null
);

this.add_main_option(
'ping',
0,
Expand Down Expand Up @@ -706,9 +697,6 @@ const Service = GObject.registerClass({
if (options.contains('notification'))
this._cliNotify(id, options);

if (options.contains('photo'))
this._cliAction(id, 'photo');

if (options.contains('ping'))
this._cliAction(id, 'ping', GLib.Variant.new_string(''));

Expand Down
Loading

0 comments on commit f077766

Please sign in to comment.