refactor: port to Gio._promisify()
#1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyholmes
force-pushed
the
andyholmes/mdns
branch
4 times, most recently
from
bb4d652
to
d91993c
Compare
andyholmes
added
the
enhancement
andyholmes
force-pushed
the
andyholmes/mdns
branch
from
d91993c
to
3592a1f
Compare
ferdnyc
reviewed
Aug 1, 2023
This tech-preview isn't going anywhere, and in fact will become a part of GJS soon. Port to the more modern async-await patterns throughout the service.
andyholmes
force-pushed
the
andyholmes/mdns
branch
from
3592a1f
to
89514e4
Compare
|
I'm going to go ahead and take that as a review :) Hopefully with this and other recent fixes it may be possible to actually generate coverage for the tests. I think that'll probably be good to have, considering the inertia this project has despite the slow development rate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tech-preview isn't going anywhere, and in fact will become a part
of GJS soon. Port to the more modern async-await patterns throughout
the service.
Depends on #1655