GNOME 45 port of Shell extension #1679

retrixe · 2023-09-17T13:13:29Z

Migrate code over to ESM.
Migrate prefs.js and extension.js to export needed objects.
Drop 'use strict' from ES Modules since it's unneeded as per JS spec.
Drop gettext and getIcon helpers on Extension.
Drop usages of ByteArray in favour of TextDecoder.
Drop var in favour of export let.
Remove __init__.js, move its setup code to a function in utils.js
Work around GNOME Shell not exporting some values to notification.js
Add workarounds for config.js/remote.js to be imported from ES modules
Use new Quick Settings API to add tile.
Update ESLint settings to support ES modules and newer JS features
Update _ornamentLabel name, fixes quick settings

- Migrate most code over to ESM. - Migrate prefs.js and extension.js to export needed objects. - Drop 'use strict' from ES Modules since it's unneeded as per JS spec. - Drop gettext and getIcon helpers on Extension. - Drop usages of ByteArray in favour of TextDecoder. - Drop `var` in favour of `export let`. - Add some FIXME comments.

Until the rest of the codebase is migrated to ESM, I don't see a better way other than duplicating code into .mjs files which is not much better

andyholmes

Nicely done!

I didn't look too deep, since there's just a lot of maintenance to do everywhere in GSCOnnect, so just a few tweaks and I think this will be good to merge.

However, the metadata.json will have to be updated to "45" as the shell-version.

src/extension.js

retrixe · 2023-09-17T22:49:25Z

It seems I'm experiencing a major issue on Fedora 39 + GNOME 45, where my device is seemingly unable to receive information from GSConnect despite being connected. I can see current info about the phone in my GSConnect menu and receive notifications and everything else, but I can't see laptop battery info, media players, receive files from laptop, etc from the phone. These did work fine with the stable GNOME 44 version (and Valent w/ GNOME 45 port works fine too).

I'm not sure what the root cause could be, seeing that the service and preferences are separate (and using the buttons there don't work either), and there are seemingly no relevant errors or stack traces in journalctl -xe or the generated support log.

andyholmes · 2023-09-17T22:53:07Z

It seems I'm experiencing a major issue on Fedora 39 + GNOME 45, where my device is seemingly unable to receive information from GSConnect despite being connected...

I would guess this is because GSConnect can now run on multiple ports, while an older instance may bind port 1716 and disallow re-use. Short answer: make sure you kill all existing instances of GSConnect and only the version you're working on is running.

retrixe · 2023-09-17T23:06:13Z

This doesn't seem to be the case, I only have a single GSConnect daemon running, and the issue persists after a system restart as well :/

andyholmes · 2023-09-18T02:56:26Z

This doesn't seem to be the case, I only have a single GSConnect daemon running, and the issue persists after a system restart as well :/

Yeah, I can confirm this. I don't really know what's causing it, since backing up to main branch it seems to work fine. I guess the service may be importing something shared that's getting it confused?

retrixe · 2023-09-18T21:05:36Z

It's not the .mjs files causing it, the imports are read correctly in the preferences and service from my logging, and the only imports that are shared appear to be those files, the rest are all isolated.

Nothing outside src/shell is importing from src/shell, same goes for extension.js and prefs.js (used regex imports\.(?!gi)(?!system)(?!searchPath)(?!config)(?!utils)(?!preferences)(?!byteArray)(?!format)(?!service)(?!tweener)(?!remote)(?!gettext)(?!wl_clipboard) to check)

Perhaps it's a change in gjs/gi libraries that affects something in the service, will try to look into it further :/

andyholmes · 2023-09-18T22:08:15Z

Perhaps it's a change in gjs/gi libraries that affects something in the service, will try to look into it further :/

I don't believe so, I just pulled from main and restarted the daemon and it worked fine. Logs from kdeconnect-android may be more enlightening though.

andyholmes · 2023-09-18T22:21:43Z

Actually, seems to work for me now. Is nothing being printed in the log that's any help? I assume you're running with debug enabled?

retrixe · 2023-09-19T04:36:35Z

Well, this is really weird, I just restarted KDE Connect on my phone and the daemon works fine now lol
Switching the daemon off and then on also reconnects properly (although there is a slight delay before the phone starts responding/receives any requests to e.g. Ring in the first place), not sure how this bug came about in the first place, but I guess this has nothing to do with this PR after all.

FWIW yes, I was using debug and the only logs I saw were about sending/receiving data and few unrelated errors wrt SFTP. Not sure how to fetch logs from kdeconnect-android (adb logcat doesn't seem to have many relevant logs), but the bug isn't occurring anymore and I'm not able to repro it anymore

andyholmes · 2023-09-19T05:21:26Z

Okay, cool, is there anything left to resolve? I think this is good enough to get some testing. GNOME 45 is released in a few days, so it would good to get some broader testing.

retrixe · 2023-09-19T06:17:07Z

Nope, everything is complete and ready to merge 👍

andyholmes · 2023-09-19T06:50:07Z

Thanks so much for working through this!

kloczek · 2023-10-23T01:19:03Z

Is it anything else still on outstanding list which holds new version released with GNOME 45 support? 🤔

andyholmes · 2023-10-23T06:03:03Z

#1694 needs to be fixed, probably as a part of #1683, although it could just be patched.

kloczek · 2023-10-23T10:28:01Z

Thank you to let me know 👍

retrixe added 7 commits September 17, 2023 15:18

Remove __init__ and initialise Config correctly

9104ddb

Fix NotificationDaemon patching, missing super()

964a7a9

Fix legacy imports with hacky workaround

760c623

Until the rest of the codebase is migrated to ESM, I don't see a better way other than duplicating code into .mjs files which is not much better

Fix errors opening GSConnect extension settings

bad856a

Fix error adding quick settings tile, import error

acc653d

Fix ESLint errors in test suite

e432440

retrixe force-pushed the feat/gnome-45-support branch from bac13e7 to e432440 Compare September 17, 2023 13:30

retrixe marked this pull request as draft September 17, 2023 13:38

retrixe marked this pull request as ready for review September 17, 2023 18:00

Update _ornamentLabel name, fixes quick settings

ffb2942

andyholmes requested changes Sep 17, 2023

View reviewed changes

src/extension.js Outdated Show resolved Hide resolved

src/extension.js Outdated Show resolved Hide resolved

retrixe force-pushed the feat/gnome-45-support branch from 52e52b5 to ed3a1e3 Compare September 17, 2023 21:50

Remove unneeded exports, set metadata to GNOME 45

19efb12

retrixe force-pushed the feat/gnome-45-support branch from ed3a1e3 to 19efb12 Compare September 17, 2023 21:51

retrixe added 2 commits September 18, 2023 03:26

Enable legacy imports and use them for old modules

daa4960

Bridge ES/legacy modules with .mjs re-export files

728e137

retrixe force-pushed the feat/gnome-45-support branch from daded42 to 728e137 Compare September 17, 2023 22:21

andyholmes approved these changes Sep 19, 2023

View reviewed changes

andyholmes merged commit eb4997a into GSConnect:main Sep 19, 2023
2 checks passed

andyholmes mentioned this pull request Sep 19, 2023

WIP: Port to gnome 45 #1674

Closed

crashbit666 mentioned this pull request Sep 20, 2023

Gsconnect release with gnome 45 support #1680

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GNOME 45 port of Shell extension #1679

GNOME 45 port of Shell extension #1679

retrixe commented Sep 17, 2023 •

edited

Loading

andyholmes left a comment

retrixe commented Sep 17, 2023 •

edited

Loading

andyholmes commented Sep 17, 2023

retrixe commented Sep 17, 2023

andyholmes commented Sep 18, 2023

retrixe commented Sep 18, 2023 •

edited

Loading

andyholmes commented Sep 18, 2023

andyholmes commented Sep 18, 2023 •

edited

Loading

retrixe commented Sep 19, 2023

andyholmes commented Sep 19, 2023

retrixe commented Sep 19, 2023

andyholmes commented Sep 19, 2023

kloczek commented Oct 23, 2023 •

edited

Loading

andyholmes commented Oct 23, 2023

kloczek commented Oct 23, 2023

GNOME 45 port of Shell extension #1679

GNOME 45 port of Shell extension #1679

Conversation

retrixe commented Sep 17, 2023 • edited Loading

andyholmes left a comment

Choose a reason for hiding this comment

retrixe commented Sep 17, 2023 • edited Loading

andyholmes commented Sep 17, 2023

retrixe commented Sep 17, 2023

andyholmes commented Sep 18, 2023

retrixe commented Sep 18, 2023 • edited Loading

andyholmes commented Sep 18, 2023

andyholmes commented Sep 18, 2023 • edited Loading

retrixe commented Sep 19, 2023

andyholmes commented Sep 19, 2023

retrixe commented Sep 19, 2023

andyholmes commented Sep 19, 2023

kloczek commented Oct 23, 2023 • edited Loading

andyholmes commented Oct 23, 2023

kloczek commented Oct 23, 2023

retrixe commented Sep 17, 2023 •

edited

Loading

retrixe commented Sep 17, 2023 •

edited

Loading

retrixe commented Sep 18, 2023 •

edited

Loading

andyholmes commented Sep 18, 2023 •

edited

Loading

kloczek commented Oct 23, 2023 •

edited

Loading