-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GNOME 47 to version list #1866
Conversation
I rubber-stamped the last one and it didn't go well, so I'll let someone actively using GSConnect approve this one. |
If you provide me a build, I'm happy to test |
@derkrasseleo You can download a build by going to the "Checks" subtab, clicking "CI" on the left, and then clicking the "[email protected]" link at the bottom of the page in "Build Artifacts". Use the Wiki "Install from Zip" instructions to upgrade. (DON'T Follow the link in this comment, it's an auto-parsed link that goes nowhere.) |
Thanks, seems to work fine for me on arch with Gnome 47 and Pixel 4a with KDE Connect |
Given the reported success from @derkrasseleo (and a couple of other users in #1863, who made the But not safe enough for me to feel right about administratively overriding the approval merge requirement, so one of @andyholmes, @sonnyp, @daniellandau still needs to give the nod before it can be merged. (@daniellandau would also need to do the release of v58, to get it out there on e.g.o. Though I can certainly put together a release PR, if that'd help?) |
Well, we've had one report in #1863 of GSConnect "not auto-starting at boot" with GNOME 47. I've requested a lot more info from the user, I guess we'll see what comes of that. |
@andyholmes |
@andyholmes already explained why he's not the dev to approve this, which I can respect. There are others. (Theoretically, at least. Or, worst-case scenario I do have the power to push this through without a review approval. I'm just very reluctant to make that particular flex.) |
Well, Ubuntu 24.10 is out for something like two weeks already, with GNOME 47, and Fedora 41 (same) is nearing readiness as well. (Decision is to be made today about a release next Tuesday; it looks like a bug with VNC installations not accepting input might push things one more week, but either way it's imminent.) So, in the interest of getting GSConnect v58 released, I'm going to push this through without secondary approval, and on my head be it if something breaks. |
And Fedora 41 was indeed designated "Go" for release on Tuesday; the couple of outstanding bugs were determined to either have a fix available, or not be serious enough to block the release. So, this was good timing. (This isn't to imply that Fedora releases are more motivating than Ubuntu releases, when it comes to having compatible GSConnect builds available. The difference is simply that I follow Fedora releases, but not Ubuntu releases, so I had no idea (until I checked earlier today) that Ubuntu 24.10 had already been released two weeks ago. Oops.) |
AFAICT based on https://gjs.guide/extensions/upgrading/gnome-shell-47.html, there's nothing else to do for compatibility.
Fixes #1863
I think once this and #1860 are merged, it's probably time for a release. There are several unreleased fixes GNOME 46 users will benefit from, as well.