-
Notifications
You must be signed in to change notification settings - Fork 125
AE2Stuff #700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
AE2Stuff #700
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a Super Wireless Kit along with new wireless connector/hub blocks, additional configuration options, GUI widgets, and network visualisation improvements. Key changes include:
- New configuration entries and getters for wireless connector power in AEConfig.
- Several new or updated GUI components (e.g. GuiImgButton, GuiColorButton, GuiCheckBox, GuiGrower) and rendering code for network visualisation.
- Additions and modifications to block/item definitions, API enums, and settings to support the new wireless features.
Reviewed Changes
Copilot reviewed 120 out of 120 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
AEConfig.java | Adds new configuration fields and accessors for wireless connector power parameters. |
ContainerGrower.java | Introduces a container for the new Crystal Growth Chamber. |
WirelessTextures.java | Adds an enum for wireless textures; includes a placeholder GuiTexture method. |
NetworkVisualiserRender.java | Implements network visualisation rendering, including both node and link rendering. |
GuiImgButton.java | Registers new apps for the Super Wireless Tool group settings. |
GuiColorButton.java | Provides a new GUI button for color selection. |
GuiCheckBox.java | Adds a scalable toggle button with custom positioning. |
GuiGrower.java | Implements the GUI for the new Grower block. |
ClientHelper.java | Registers new event listeners and texture initialisations for wireless elements. |
BlockWirelessHub.java | Defines a wireless hub block that uses the new wireless textures. |
BlockWirelessConnector.java | Modifies wireless connector block drop and icon behaviour based on color. |
BlockGrower.java | Implements a Grower block with unique activation and icon registration. |
AEBaseBlock.java | Updates subtype settings and information methods in the base block implementation. |
IItems.java, IBlocks.java | Adds new definitions for toolSuperWirelessKit and wireless blocks. |
SuperWirelessTool*, Settings.java | Introduces new enums and settings values to support the Super Wireless Kit. |
ActionItems.java | Extends action items with new options used by the wireless tool. |
Comments suppressed due to low confidence (2)
src/main/java/appeng/client/texture/WirelessTextures.java:102
- The method 'GuiTexture' currently returns null; consider providing a proper implementation or a default texture resource if this is not intentional.
return null;
src/main/java/appeng/api/config/ActionItems.java:37
- [nitpick] The action item 'MOVE_TO_TO_BIND' is confusing; consider renaming it to improve clarity (for example, 'MOVE_TO_BIND_TARGET').
MOVE_TO_TO_BIND
src/main/java/appeng/block/networking/BlockWirelessConnector.java
Outdated
Show resolved
Hide resolved
src/main/java/appeng/block/networking/BlockWirelessConnector.java
Outdated
Show resolved
Hide resolved
@Override | ||
public void setHasSubtypes(boolean b) { | ||
super.setHasSubtypes(true); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be done in the constructor rather than an override?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not working correct on constructor. Different meta items stacking in one stack...
This incldue wireless connector and hub, network visualisation tool.
Crystal Growth Chamber added.
Pattern Encoder and Advanced Inscriber and wireless tools will not add.
WIP but i want some feedback about gui & functions