Skip to content

AE2Stuff #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

AE2Stuff #700

wants to merge 22 commits into from

Conversation

lc-1337
Copy link

@lc-1337 lc-1337 commented Mar 26, 2025

This incldue wireless connector and hub, network visualisation tool.
Crystal Growth Chamber added.
Pattern Encoder and Advanced Inscriber and wireless tools will not add.
WIP but i want some feedback about gui & functions

@Dream-Master Dream-Master requested a review from a team March 26, 2025 12:42
@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Mar 26, 2025
@Pxx500 Pxx500 requested a review from Copilot March 28, 2025 08:24
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a Super Wireless Kit along with new wireless connector/hub blocks, additional configuration options, GUI widgets, and network visualisation improvements. Key changes include:

  • New configuration entries and getters for wireless connector power in AEConfig.
  • Several new or updated GUI components (e.g. GuiImgButton, GuiColorButton, GuiCheckBox, GuiGrower) and rendering code for network visualisation.
  • Additions and modifications to block/item definitions, API enums, and settings to support the new wireless features.

Reviewed Changes

Copilot reviewed 120 out of 120 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
AEConfig.java Adds new configuration fields and accessors for wireless connector power parameters.
ContainerGrower.java Introduces a container for the new Crystal Growth Chamber.
WirelessTextures.java Adds an enum for wireless textures; includes a placeholder GuiTexture method.
NetworkVisualiserRender.java Implements network visualisation rendering, including both node and link rendering.
GuiImgButton.java Registers new apps for the Super Wireless Tool group settings.
GuiColorButton.java Provides a new GUI button for color selection.
GuiCheckBox.java Adds a scalable toggle button with custom positioning.
GuiGrower.java Implements the GUI for the new Grower block.
ClientHelper.java Registers new event listeners and texture initialisations for wireless elements.
BlockWirelessHub.java Defines a wireless hub block that uses the new wireless textures.
BlockWirelessConnector.java Modifies wireless connector block drop and icon behaviour based on color.
BlockGrower.java Implements a Grower block with unique activation and icon registration.
AEBaseBlock.java Updates subtype settings and information methods in the base block implementation.
IItems.java, IBlocks.java Adds new definitions for toolSuperWirelessKit and wireless blocks.
SuperWirelessTool*, Settings.java Introduces new enums and settings values to support the Super Wireless Kit.
ActionItems.java Extends action items with new options used by the wireless tool.
Comments suppressed due to low confidence (2)

src/main/java/appeng/client/texture/WirelessTextures.java:102

  • The method 'GuiTexture' currently returns null; consider providing a proper implementation or a default texture resource if this is not intentional.
return null;

src/main/java/appeng/api/config/ActionItems.java:37

  • [nitpick] The action item 'MOVE_TO_TO_BIND' is confusing; consider renaming it to improve clarity (for example, 'MOVE_TO_BIND_TARGET').
MOVE_TO_TO_BIND

@lc-1337 lc-1337 changed the title AE2Stuff + Super Wireless Kit AE2Stuff Apr 2, 2025
@lc-1337 lc-1337 mentioned this pull request Apr 19, 2025
Comment on lines +39 to +42
@Override
public void setHasSubtypes(boolean b) {
super.setHasSubtypes(true);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be done in the constructor rather than an override?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not working correct on constructor. Different meta items stacking in one stack...

@Dream-Master Dream-Master requested a review from serenibyss May 14, 2025 17:08
@Dream-Master Dream-Master requested a review from a team May 29, 2025 10:45
@boubou19 boubou19 added the ongoing freeze - do not merge Not just a bug fix and thus affected by a current freeze for a upcoming version label Jun 1, 2025
@Caedis Caedis removed the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Jun 11, 2025
@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta ongoing freeze - do not merge Not just a bug fix and thus affected by a current freeze for a upcoming version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants