Make kotlin spotless config work #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turned out, these weren't working quite right as the indentation settings weren't taking effact. Switch to ktlint for j8 compat.
glektarssza
approved these changes
Oct 30, 2025
Member
glektarssza
left a comment
glektarssza
left a comment
There was a problem hiding this comment.
Looks good to me. Seems to work fine in my IDE as well (VSCode). 🚢!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While @Kynake was working on a port of BetterFoliage to our buildscripts they noticed that our kotlin formatting settings weren't working. It turned out that
indentWithSpacesdidn't seem to take effect. Instead, we move that setting into the formatter directly. Switch toktlintfor java 8 compatibility. This should be fine as we currently have 2.5 or so mods with kotlin in them.This also updates the targeted files for kotlin as for example BetterP2P has them in
src/main/java.