fix: reuse system metrics in nodes on mlflow.start_run #647
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the current measures to make kedro-mlflow work with thread safety in MLFlow, technically a call to
mlflow.start_run()
is happening on every node with the samerun_id
. While having logging of system metrics enabled this means, a newSystemMetricMonitor
will be started for every node with the samerun_id
(source code). The pipeline will run slower and slower, until it stops progressing (I couldn't run a pipeline with ~200 nodes, stopped ~50)Development notes
One line change - set parameter
log_system_metrics=False
inmlflow.start_run()
forbefore_node_run
hook.Added test that checks whether the SystemMetricMonitor is the same after running a node.
Checklist
CHANGELOG.md
file. Please respect Keep a Changelog guidelines.Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.