saw-core-coq: Define newtype for Coq Ident and ModuleName types. #2435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like I managed to introduce some extra quotation marks in my |
|
There's also a more serious problem with how to distinguish module names that have and have not been translated yet. There doesn't seem to be a good way to properly disentangle these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1253.
I did the best I could to figure out which instances of
StringandIdentwere pre-translation and which were post-translation, but the code was undisciplined and mixed up the levels in a couple of places, so it was necessary to make a few changes beyond just inserting newtype coercions. I tried to preserve the output behavior of the translation in these cases.