Skip to content

Remove GADTs and simplify module SAWCore.Term.CtxTerm #2455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Jul 2, 2025
Merged

Conversation

brianhuffman
Copy link
Contributor

This is a step toward removing the dependence of this module on de Bruijn indices (see #2438).

@brianhuffman brianhuffman marked this pull request as ready for review July 1, 2025 12:23
@brianhuffman
Copy link
Contributor Author

A few high-level comments:

@brianhuffman
Copy link
Contributor Author

Fun stats from git:

% git diff master | diffstat
 Module.hs       |    7
 SharedTerm.hs   |    4
 Term/CtxTerm.hs | 1156 ++++++++++++++++++---------------------------------------------
 Typechecker.hs  |   46 +-
 4 files changed, 358 insertions(+), 855 deletions(-)

So overall this PR has removed about 500 lines of code from saw-core. Woohoo!

@brianhuffman brianhuffman merged commit 263b8c4 into master Jul 2, 2025
37 checks passed
@brianhuffman brianhuffman deleted the bh/ctxterm branch July 2, 2025 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants