Skip to content

Tullsen/cryptol saw core use no debruijn api #2457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jul 2, 2025

Conversation

mtullsen
Copy link
Contributor

@mtullsen mtullsen commented Jul 1, 2025

A refactor (though large), of SawCore/Cryptol.hs to use the newer non-DeBruijn API for creating SAWCore.

@mtullsen mtullsen self-assigned this Jul 1, 2025
@mtullsen mtullsen added the tech debt Issues that document or involve technical debt label Jul 1, 2025
@mtullsen
Copy link
Contributor Author

mtullsen commented Jul 1, 2025

Just getting CI results, a version ready for review coming very soon.

@sauclovian-g
Copy link
Contributor

Test failures are just renumbering again.

@brianhuffman
Copy link
Contributor

brianhuffman commented Jul 1, 2025

It looks like the CI test is failing on intTests/test_llvm_errors for a boring reason: The expected test output file intTests/test_llvm_errors/err001.log.good needs to be updated because some VarIndexes that show up in the output have changed. Same for intTests/test2049/test.log.1.good and test.log.2.good (I had to update these same files quite recently in d46d4ae.)

@mtullsen
Copy link
Contributor Author

mtullsen commented Jul 1, 2025

It looks like the CI test is failing on intTests/test_llvm_errors for a boring reason: The expected test output file intTests/test_llvm_errors/err001.log.good needs to be updated because some VarIndexes that show up in the output have changed. Same for intTests/test2049/test.log.1.good and test.log.2.good (I had to update these same files quite recently in d46d4ae.)

NOTED. I was delaying doing this till after any/all refactorings were done, :-)

@mtullsen mtullsen marked this pull request as ready for review July 2, 2025 05:21
@mtullsen mtullsen merged commit 7028379 into master Jul 2, 2025
37 checks passed
@mtullsen mtullsen deleted the tullsen/cryptol-saw-core-use-no-debruijn-api branch July 2, 2025 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Issues that document or involve technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants