Skip to content

Typing: contact #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Jun 17, 2024
Merged

Conversation

skim0119
Copy link
Collaborator

@skim0119 skim0119 commented Jun 15, 2024

blocked by #396

Changes

  • memory_block/memory_block_rod_base.py utility functions are moved into memory_block/utils.py. Soft-link is provided in the original file for backward compatiblity.

Minor Changes

  • Rework: Object type validation for contact module
    • Using typing, clean out any contact module that does not satisfy Liskov substitution property
    • Remove duplicated code: message for validation check
    • Update tests

@skim0119 skim0119 self-assigned this Jun 15, 2024
@skim0119 skim0119 added the enhancement New feature or request label Jun 15, 2024
@skim0119 skim0119 mentioned this pull request Jun 15, 2024
17 tasks
@armantekinalp armantekinalp marked this pull request as ready for review June 17, 2024 13:33
@armantekinalp armantekinalp requested a review from bhosale2 as a code owner June 17, 2024 13:33
@armantekinalp armantekinalp merged commit fc4a303 into GazzolaLab:update/mypy Jun 17, 2024
6 checks passed
@skim0119 skim0119 deleted the typing/contact branch June 19, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants