Hierarchical builtins #240
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some hierarchy in the typed builtins. Previously all the builtins lived in a flat namespace, but now there is (most of the time) one extensible constructor builtin by theory, which wraps a dedicated (regular) type for the builtins of that theory. This brings a few benefits:
Note that this is a rather large breaking change, since it will likely require to update any pattern matching on builtins, but the translation should be rather mechanical. It is not completely mechanical because I took the opportunity to rename some builtins, taking advantage of the now different namespaces for builtins of different theories (and also to avoid repetitions like
| Builtin.Float Fp_foo -> ...).cc @bobot , in particular for the new names of primitives in the Float theory.