Skip to content

Comments

kwargs protection: core GMT modules#1920

Merged
joa-quim merged 1 commit intomasterfrom
kwargs-protect-core
Feb 17, 2026
Merged

kwargs protection: core GMT modules#1920
joa-quim merged 1 commit intomasterfrom
kwargs-protect-core

Conversation

@joa-quim
Copy link
Member

Summary

  • Split entry points from main logic in core module wrappers so that kwargs are converted to Dict{Symbol,Any} via init_module in thin wrappers before calling the main function
  • Affected modules: blocks (blockmean/blockmedian/blockmode), filter1d, fitcircle, gmt2kml, gmtconnect, gmtregress, gmtselect, gmtset, gmtsimplify, gmtvector, gmtwhich, earthtide, kml2gmt, movie, project, mapproject

Test plan

  • All Vd=2 smoke tests pass
  • test_B-GMTs.jl passes
  • test_P_a_T.jl passes (project, mapproject)
  • Actual execution tests pass

🤖 Generated with Claude Code

Split entry points from main logic in core module wrappers
so that kwargs are converted to Dict{Symbol,Any} via init_module
in thin wrappers before calling the main function.

Affected modules: blocks (blockmean/blockmedian/blockmode),
filter1d, fitcircle, gmt2kml, gmtconnect, gmtregress, gmtselect,
gmtset, gmtsimplify, gmtvector, gmtwhich, earthtide, kml2gmt,
movie, project, mapproject.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2026

Codecov Report

❌ Patch coverage is 94.38202% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.88%. Comparing base (8913842) to head (5fe66f8).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/blocks.jl 90.90% 2 Missing ⚠️
src/fitcircle.jl 83.33% 1 Missing ⚠️
src/gmt2kml.jl 83.33% 1 Missing ⚠️
src/gmtsimplify.jl 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1920      +/-   ##
==========================================
+ Coverage   85.68%   85.88%   +0.19%     
==========================================
  Files         187      187              
  Lines       27524    27559      +35     
==========================================
+ Hits        23584    23669      +85     
+ Misses       3940     3890      -50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joa-quim joa-quim merged commit 5b0da01 into master Feb 17, 2026
4 of 7 checks passed
@joa-quim joa-quim deleted the kwargs-protect-core branch February 17, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants