Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heavy_metals description and guidance is NOT LinkML appropriate #860

Open
mslarae13 opened this issue Sep 19, 2024 · 1 comment
Open

heavy_metals description and guidance is NOT LinkML appropriate #860

mslarae13 opened this issue Sep 19, 2024 · 1 comment
Assignees

Comments

@mslarae13
Copy link
Contributor

https://genomicsstandardsconsortium.github.io/mixs/0000652/

Current:

heavy_metals:
    annotations:
      Expected_value: heavy metal name;measurement value unit
      Preferred_unit: microgram per gram
    description: Heavy metals present in the sequenced sample and their concentrations.
      For multiple heavy metals and concentrations, add multiple copies of this field

Description's guidance, "For multiple heavy metals and concentrations, add multiple copies of this field"
You can't do this in LinkML & this guidance won't validation.
Rather, it should be a compound field separated by a ; or | (See #465 (comment))

so ...

examples:
    - value: mercury;0.09 micrograms per gram

Change to

examples:
    - value: mercury,0.09 micrograms per gram
    - value: mercury,0.09 micrograms per gram | lead,0.05 micrograms per gra,

@mslarae13 mslarae13 self-assigned this Sep 19, 2024
@turbomam
Copy link
Member

turbomam commented Sep 24, 2024

i agree with this, but we should review our exceptions about using whitespace between the pipe delimiter and the values on either side. I think that the following example

"mercury,0.09 micrograms per gram | lead,0.05 micrograms per gram"

would be expanded to these by most software applications

  • "mercury,0.09 micrograms per gram "
  • " lead,0.05 micrograms per gram"

So I would have written the example as "mercury,0.09 micrograms per gram|lead,0.05 micrograms per gram"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants