Skip to content

[Fixes #13166] Clean up the base.html #13176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 16, 2025
Merged

[Fixes #13166] Clean up the base.html #13176

merged 6 commits into from
May 16, 2025

Conversation

Gpetrak
Copy link
Contributor

@Gpetrak Gpetrak commented May 12, 2025

This PR was created according to this issue: #13166

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@Gpetrak Gpetrak requested a review from giohappy May 12, 2025 13:15
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label May 12, 2025
@Gpetrak Gpetrak added this to the 5.0.0 milestone May 12, 2025
@Gpetrak Gpetrak linked an issue May 12, 2025 that may be closed by this pull request
Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.09%. Comparing base (42c7b08) to head (3d2652f).
Report is 6 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (42c7b08) and HEAD (3d2652f). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (42c7b08) HEAD (3d2652f)
api 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13176      +/-   ##
==========================================
- Coverage   72.58%   66.09%   -6.49%     
==========================================
  Files         927      927              
  Lines       52976    52976              
  Branches     6075     6075              
==========================================
- Hits        38452    35016    -3436     
- Misses      12953    16437    +3484     
+ Partials     1571     1523      -48     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Gpetrak Gpetrak marked this pull request as ready for review May 13, 2025 13:38
@Gpetrak Gpetrak marked this pull request as draft May 13, 2025 13:45
@Gpetrak Gpetrak marked this pull request as ready for review May 14, 2025 08:30
@mattiagiupponi mattiagiupponi requested review from mattiagiupponi and removed request for giohappy May 16, 2025 13:15
@mattiagiupponi mattiagiupponi self-assigned this May 16, 2025
@mattiagiupponi mattiagiupponi merged commit 7190d3c into master May 16, 2025
16 of 17 checks passed
@mattiagiupponi mattiagiupponi deleted the ISSUE_13166 branch May 16, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up base.html template to remove legacy and unused code
2 participants