Skip to content

[Fixes #13987] Management command over HTTP job status error fix#13989

Merged
mattiagiupponi merged 1 commit intomasterfrom
ISSUE_13987
Feb 25, 2026
Merged

[Fixes #13987] Management command over HTTP job status error fix#13989
mattiagiupponi merged 1 commit intomasterfrom
ISSUE_13987

Conversation

@sijandh35
Copy link
Contributor

Fixes #13987

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@sijandh35 sijandh35 self-assigned this Feb 24, 2026
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Feb 24, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @sijandh35, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug in the get_celery_task_meta utility function, which is responsible for retrieving the status of asynchronous management command jobs executed over HTTP. The fix ensures robust handling of Celery task IDs, preventing errors that could arise from incorrect type usage when querying task metadata and improving the reliability of job status reporting.

Highlights

  • Celery Task ID Type Fix: The celery_result_id is now explicitly converted to a string before being used to retrieve Celery task metadata. This resolves a potential type mismatch error when fetching the status of asynchronous jobs.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • geonode/management_commands_http/utils/jobs.py
    • Converted job.celery_result_id to a string before passing it to AsyncResult and get_task_meta.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request effectively addresses a potential type mismatch by explicitly converting the celery_result_id to a string before interacting with Celery's API. This ensures the correct retrieval of task metadata, preventing runtime errors and enhancing the robustness of the job status functionality.

Comment on lines +42 to +44
celery_result_id = str(job.celery_result_id)
async_result = run_management_command_async.AsyncResult(celery_result_id)
task_meta = async_result.backend.get_task_meta(celery_result_id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The explicit conversion of job.celery_result_id to a string is crucial here. As celery_result_id is a UUIDField in the ManagementCommandJob model, it is retrieved as a UUID object. Celery's AsyncResult and backend.get_task_meta expect a string representation of the task ID, so this conversion correctly handles the type, preventing potential TypeError exceptions and ensuring reliable task status retrieval.

@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.25%. Comparing base (7f6c030) to head (8152d77).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13989      +/-   ##
==========================================
+ Coverage   74.07%   74.25%   +0.18%     
==========================================
  Files         950      950              
  Lines       56826    56798      -28     
  Branches     7719     7699      -20     
==========================================
+ Hits        42093    42176      +83     
+ Misses      13044    12926     -118     
- Partials     1689     1696       +7     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sijandh35 sijandh35 assigned sijandh35 and unassigned sijandh35 Feb 24, 2026
@mattiagiupponi mattiagiupponi merged commit 7214faf into master Feb 25, 2026
17 of 18 checks passed
@mattiagiupponi mattiagiupponi deleted the ISSUE_13987 branch February 25, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Management command over HTTP job status throws error on async

2 participants