Skip to content

first working implementation with user text selection preventing swipe #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GeoloeG-IsT wants to merge 1 commit into
base: master
Choose a base branch
from
Open

first working implementation with user text selection preventing swipe #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions demo/mobile.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,6 @@
height: 100%;
}

iron-swipeable-pages > * {
-webkit-user-select: none; /* Chrome all / Safari all */
-moz-user-select: none; /* Firefox all */
-ms-user-select: none; /* IE 10+ */
user-select: none; /* Likely future */
cursor: default;
}

div {
color: white;
font-size: 2rem;
Expand Down
25 changes: 21 additions & 4 deletions iron-swipeable-pages.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,24 @@
this.setScrollDirection('y');
},

attached: function() {
document.addEventListener("selectionchange", this._onSelectionChange.bind(this));
},

detached: function() {
document.removeEventListener("selectionchange", this._onSelectionChange.bind(this));
},

_onSelectionChange: function(event) {
var selection = document.getSelection();
var range = selection ? selection.getRangeAt(0) : undefined;
if (range && range.startOffset != range.endOffset) {
this._swipeDisabled = true;
} else {
this._swipeDisabled = false;
}
},

// Element page set up

_onItemsChanged: function(event) {
Expand All @@ -183,14 +201,14 @@
_addPage: function(page) {
if (page.nodeType !== Node.ELEMENT_NODE)
return;
// TODO PG: check for webkit 'webkitTransitionEnd'
this.listen(page, 'webkitTransitionEnd', '_onTransitionEnd');
this.listen(page, 'transitionend', '_onTransitionEnd');
},

_removePage: function(page) {
if (page.nodeType !== Node.ELEMENT_NODE)
return;
// TODO PG: check for webkit 'webkitTransitionEnd'
this.unlisten(page, 'webkitTransitionEnd', '_onTransitionEnd');
this.unlisten(page, 'transitionend', '_onTransitionEnd');
},

Expand All @@ -212,8 +230,7 @@
_onTrack: function(event) {
var track = event.detail;

if (this.noCycle && !this._canCycle(track)) {
// TODO PG: eventually provide an animation to show the swiping blocking
if (this._swipeDisabled || (this.noCycle && !this._canCycle(track))) {
return;
}

Expand Down