Skip to content

Merge develop to stable#1259

Merged
robbibt merged 3 commits intostablefrom
develop
Aug 6, 2024
Merged

Merge develop to stable#1259
robbibt merged 3 commits intostablefrom
develop

Conversation

@robbibt
Copy link
Member

@robbibt robbibt commented Aug 6, 2024

Proposed changes

Includes updates from Slack to Discord, and minor changes to notebook order in Knowledge Hub

Closes issues (optional)

  • Closes Issue #000

Checklist

(Replace [ ] with [x] to check off)

  • Notebook created using the DEA-notebooks template
  • Remove any unused Python packages from Load packages
  • Remove any unused/empty code cells
  • Remove any guidance cells (e.g. General advice)
  • Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
  • Include relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
  • Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
  • Test notebook on both the NCI and DEA Sandbox (flag if not working as part of PR and ask for help to solve if needed)
  • If applicable, update the Notebook currently compatible with the NCI|DEA Sandbox environment only line below the notebook title to reflect the environments the notebook is compatible with
  • Check for any spelling mistakes using the DEA Sandbox's built-in spellchecker (double click on markdown cells then right-click on pink highlighted words). For example:

sandbox_spellchecker

benji-glitsos-ga and others added 3 commits August 5, 2024 09:42
* Update test_temporal.py

* Skip broken datasets

* Skip broken datasets

* Skip broken datasets

* Fix docker compose in workflow

* Missing docker compose

* Update test_temporal.py
* Moved GeoMAD notebook in the sidebar to reflect the order of products in
the KH

* Three discord links

* 3 more Discord links

* Minor case formatting change

* Multiple Discord links

* More Discord links

* Updated numerous links to discord using find-and-replace

* Two Discord links

* Multiple Discord links - find-and-replace

* Multiple discord links

* Add Discord badge

* Use consistent link format

---------

Co-authored-by: Robbi Bishop-Taylor <[email protected]>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@robbibt robbibt merged commit af20192 into stable Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants