NPI-4066 Reject SP3 files with overlong data lines#91
Merged
Conversation
ronaldmaj
approved these changes
Jul 1, 2025
Collaborator
There was a problem hiding this comment.
This is a nice PR that quickly tests for lines are too long, which is usually indicative of Ginan processing gone awry. It'll enable our rapid and ultra-rapid jobs to fail quickly when there are issues.
I've tested this with a file that was problematic - it detected all lines that exceeded the line length successfully.
Happy for this to go in 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SP3 data lines are fixed width and strictly follow a columnar layout. Misaligned data can lead to serious parsing issues, including grossly incorrect position values.
This PR adds a simple check to
read_sp3(), rejecting any SP3 data which has line(s) exceeding 80 chars.Further work is in train to more robustly check alignment by testing that all unused columns contain a space.