Refactor tests with recursive assertion method #3510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geotrek-admin
|
||||||||||||||||||||||||||||
| Project |
Geotrek-admin
|
| Branch Review |
refs/pull/3510/merge
|
| Run status |
|
| Run duration | 02m 15s |
| Commit |
|
| Committer | Marc-Antoine Dupré |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
22
|
| View all changes introduced in this branch ↗︎ | |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3510 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 267 267
Lines 20916 20916
=======================================
Hits 20579 20579
Misses 337 337 ☔ View full report in Codecov by Sentry. |
Member
|
c'ets bien mais du coup est-ce qu'i lfaudrait pas generaliser l'usage dans tous les tests de comparaison de geometries ? |
Contributor
Author
|
À la base j'ai juste mis mon exploration pour des tests en échec avec PostGIS 3+ dans une PR. Mais oui on peut laisser ouvert le temps que je fasse une passe sur les autres tests. |
marcantoinedupre
force-pushed
the
refactor-tests-with-recursive-assert
branch
from
5ab371c to
0ddcc77
Compare
marcantoinedupre
force-pushed
the
refactor-tests-with-recursive-assert
branch
from
0ddcc77 to
01ea2f9
Compare
- refactor initially started to fix flaky tests due to floating numbers comparisons, - increases robustness of this TestCase.
marcantoinedupre
force-pushed
the
refactor-tests-with-recursive-assert
branch
from
01ea2f9 to
8be6451
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Une petite PR qui ajoute une méthode maison pour faire du recursive almost equal dans les tests qui comparent des géométries.
La raison de cette PR est de corriger des flaky tests. (Même si les tests correspondants n'ont pas échoué sans raison depuis un moment)
Aucune modification des tests. J'ai juste remplacé les
self.assertEqualparself.assertRecursiveAlmostEqualpour les comparaisons de géométries.Quand il y a comparaison de plusieurs géométries j'ai ajouté une boucle
for-> je me dis que c'est plus facile de repérer la comparaison qui a échoué dans ce cas. Mais ça marcherait sans.