Skip to content

Conversation

@justinefricou
Copy link
Contributor

@justinefricou justinefricou commented Jun 12, 2025

Description

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

@cypress
Copy link

cypress bot commented Jun 12, 2025

Geotrek-admin    Run #13172

Run Properties:  status check passed Passed #13172  •  git commit 558dd73b4b ℹ️: Merge 025f5006f6f6ef7673d9ca70fd74e124c7f9c7f2 into f904d9efc3a4c1c5182201b8d582...
Project Geotrek-admin
Branch Review refs/pull/4777/merge
Run status status check passed Passed #13172
Run duration 02m 04s
Commit git commit 558dd73b4b ℹ️: Merge 025f5006f6f6ef7673d9ca70fd74e124c7f9c7f2 into f904d9efc3a4c1c5182201b8d582...
Committer Justine Fricou
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

@justinefricou justinefricou force-pushed the fix_parser_poi_no_geom_3d branch 2 times, most recently from 5f644cb to 5fc9e69 Compare June 16, 2025 10:14
@codecov
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (f904d9e) to head (025f500).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4777      +/-   ##
==========================================
- Coverage   98.46%   98.46%   -0.01%     
==========================================
  Files         271      272       +1     
  Lines       22212    22203       -9     
==========================================
- Hits        21871    21862       -9     
  Misses        341      341              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@justinefricou justinefricou changed the title Fix Apidae POI parser not generating topology Fix parsers not generating point topology Jun 17, 2025
@submarcos submarcos force-pushed the fix_parser_poi_no_geom_3d branch from 543da87 to 631ab6f Compare June 18, 2025 12:09
@justinefricou justinefricou force-pushed the fix_parser_poi_no_geom_3d branch from e390ec3 to 3e2195d Compare June 23, 2025 08:34
@justinefricou justinefricou requested a review from submarcos June 23, 2025 13:36
@justinefricou justinefricou marked this pull request as ready for review June 23, 2025 13:36
@justinefricou justinefricou marked this pull request as draft June 24, 2025 14:37
@justinefricou justinefricou marked this pull request as ready for review June 24, 2025 15:03
@justinefricou justinefricou marked this pull request as draft June 25, 2025 09:39
@justinefricou justinefricou marked this pull request as ready for review June 25, 2025 11:51
@justinefricou justinefricou requested a review from submarcos July 1, 2025 14:21
@justinefricou justinefricou merged commit 883a954 into master Jul 2, 2025
46 checks passed
@justinefricou justinefricou deleted the fix_parser_poi_no_geom_3d branch July 2, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants