-
Notifications
You must be signed in to change notification settings - Fork 80
Drop Ubuntu 20.04 support #5119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Geotrek-admin
|
||||||||||||||||||||||||||||
| Project |
Geotrek-admin
|
| Branch Review |
refs/pull/5119/merge
|
| Run status |
|
| Run duration | 02m 09s |
| Commit |
|
| Committer | Jean-Etienne Castagnede |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
22
|
| View all changes introduced in this branch ↗︎ | |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5119 +/- ##
==========================================
- Coverage 98.47% 98.46% -0.01%
==========================================
Files 272 272
Lines 22285 22285
==========================================
- Hits 21945 21944 -1
- Misses 340 341 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes support for Ubuntu 20.04 (Focal Fossa) from the Geotrek-admin project as a breaking change. The changes streamline CI/CD pipelines and build processes by removing focal-specific build configurations, test matrices, and deployment steps that are no longer needed.
Key changes:
- Removed Ubuntu Focal 20.04 from all CI/CD test and build matrices
- Cleaned up Dockerfile to remove focal-specific PPA and repository configurations
- Updated deployment workflows to exclude focal package publishing
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/changelog.rst | Documents the breaking change announcement for Ubuntu 20.04 deprecation |
| docker/Dockerfile.debian.builder | Removes focal-specific PPA setup and repository configuration for dh-virtualenv |
| .github/workflows/test.yml | Removes 'focal-3.10' from test/coverage matrices, removes focal-specific Python venv installation, removes focal debian artifact download, and removes focal package deployment commands |
Critical Issue Found: While the CI/CD and build configuration changes are complete and correct, the documentation in docs/installation-and-configuration/upgrade.rst still contains multiple references to Ubuntu Focal 20.04 that need to be updated or removed to ensure consistency with this breaking change.
|
@copilot open a new pull request to apply changes based on the comments in this thread |
|
@submarcos I've opened a new pull request, #5124, to work on those changes. Once the pull request is ready, I'll request review from you. |
Description
Related Issue
Checklist