Skip to content

Conversation

@lpofredc
Copy link
Contributor

@lpofredc lpofredc commented Dec 5, 2025

Description

Huge fix!

Related Issue

None

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file (not really necessary)
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.47%. Comparing base (8f12e1a) to head (d0bb335).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5137   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files         272      272           
  Lines       22269    22269           
=======================================
  Hits        21929    21929           
  Misses        340      340           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress
Copy link

cypress bot commented Dec 5, 2025

Geotrek-admin    Run #15049

Run Properties:  status check passed Passed #15049  •  git commit 7a2ec71527 ℹ️: Merge d0bb3359a8cddd58340e917f1cf101458f71aad3 into 8f12e1afbbe6fe0a36c32e2738dd...
Project Geotrek-admin
Branch Review refs/pull/5137/merge
Run status status check passed Passed #15049
Run duration 02m 13s
Commit git commit 7a2ec71527 ℹ️: Merge d0bb3359a8cddd58340e917f1cf101458f71aad3 into 8f12e1afbbe6fe0a36c32e2738dd...
Committer Fred C
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

@lpofredc
Copy link
Contributor Author

lpofredc commented Dec 8, 2025

Les fichiers de traduction ne semblent pas à jour sur ma branche et le CI échoue (mais ma PR n'est normalement pas concernée). En effet, la mise à jour des fichiers de traduction ajoute 2 nouvelles traduction. Dois-je les ajouter à la PR ?

msgid "Log in"
msgstr ""

msgid "Forgotten your password or username?"
msgstr ""
...

@submarcos
Copy link
Member

submarcos commented Dec 11, 2025

@lpofredc Hello. Pour les traductions, c'est autre chose, un changement dans la CI ne t'autorise pas à lancer le job de vérification des traductions. Faut que je creuse car ça a été mis en place pour justement ajouter les trads manquantes en cas d'oubli. Mais ça ne fonctionne apparemment que pour les membres de l'orga GeotrekCE. Faut que je vois pour autoriser aussi les forks, quitte à obliger les utilisateurs à les mettres à jour manuellement.

Par contre, peux-tu ajouter une entrée dans le changelog pour ta modif ?

Si tu mets le changelog, dans la mesure ou les autres tests passent, je mergerai ta PR

@submarcos submarcos changed the title Fix translation text for regulatory sensitive area parser Fix english label for sensitive area shapefile parsers Dec 11, 2025
@submarcos submarcos merged commit 537d3ca into GeotrekCE:master Dec 11, 2025
42 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants