fix: state break on channel prop update #2957
Merged
+22
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size
|
oliverlaz
approved these changes
Feb 18, 2025
khushal87
approved these changes
Feb 19, 2025
Merged
|
🎉 This PR is included in version 6.6.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
This PR addresses this GH issue.
Essentially, we were wrapping the copying of the
channelstate from our LLC in arefwhich was never updated, thus resulting in an issue whenever we don't explicitly unmount and then remount theChannelcomponent.Although it is not very common behaviour to have this working like explained on mobile devices, it is very common on tablets for example where we're aiming for more of a web-like behaviour.
🛠 Implementation details
🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
developbranch