Skip to content

fix: validate max number of poll votes based on input validity #2701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 14, 2025
+3 −2
Merged

fix: validate max number of poll votes based on input validity #2701

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
17c0a6c
feat: introduce WithDragAndDropUpload component (#2688)
arnautov-anton Apr 24, 2025
1beadf2
refactor: simplify WithDragAndDropUpload API (#2691)
arnautov-anton Apr 25, 2025
8dbb73c
chore(release): 12.15.0 [skip ci]
semantic-release-bot May 2, 2025
97710ea
fix: prevent sorting poll options in place (#2699)
MartinCupela May 8, 2025
1834bef
fix: validate the field for max number of votes correctly
MartinCupela May 8, 2025
191ed8f
Merge branch 'release-v12' into fix/validate-max-number-of-poll-votes
MartinCupela May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/components/Poll/PollCreationDialog/PollCreationDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,9 @@ export const PollCreationDialog = ({ close }: PollCreationDialogProps) => {
id='max_votes_allowed'
onChange={(e) => {
const isValidValue =
!e.target.value ||
e.target.value.match(VALID_MAX_VOTES_VALUE_REGEX);
e.target.validity.valid &&
(!e.target.value ||
e.target.value.match(VALID_MAX_VOTES_VALUE_REGEX));
if (!isValidValue) {
setMultipleAnswerCountError(
t<string>('Type a number from 2 to 10'),
Expand Down