Skip to content

Update extensions to node18 environment #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pzmudzinski
Copy link

No description provided.

@pzmudzinski pzmudzinski mentioned this pull request May 7, 2024
@skydoves
Copy link
Contributor

skydoves commented Jun 4, 2024

Hey @pzmudzinski, thank you for creating this PR! Would you also check out the CI build's testing?

@pzmudzinski
Copy link
Author

@skydoves Updated package-lock.json, let's try again.

@skydoves
Copy link
Contributor

skydoves commented Jun 5, 2024

@pzmudzinski Thanks for updating! It seems that the GitHub secrets on the CI were outdated, as the messages. I will update them to the new one, and please correct me if I'm wrong because I'm not an expertise on frontend 😄

@pzmudzinski
Copy link
Author

@skydoves I guess you need to re-run github workflow so we can check if it works now?

@skydoves
Copy link
Contributor

skydoves commented Jun 8, 2024

Hey @pzmudzinski, I think the GitHub CI configuration for the Firebase project is outdated or needs to be updated, and it will take some time. 😢 In the meantime, would you configure the secret keys and run the npm test with your Firebase project (not a production one) on your local device to double-check?

https://github.com/GetStream/stream-firebase-extensions/tree/main/integration-tests

@pzmudzinski
Copy link
Author

@skydoves It seems those tests are dependent on each other and data is not cleared correctly between tests suites. Most importantly - how this test is supposed to work? It's checking existing of some activity under user's feed but it's nowhere created in beforeAll.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants