Skip to content

[Feature]Manual Quality Selection #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2024
Merged

[Feature]Manual Quality Selection #571

merged 1 commit into from
Oct 14, 2024

Conversation

ipavlidakis
Copy link
Contributor

@ipavlidakis ipavlidakis commented Oct 10, 2024 •
edited
Loading

🔗 Issue Links

https://stream-io.atlassian.net/browse/PBE-6199

🎯 Goal

Provides a way to manually control incoming video quality settings.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (Docusaurus, tutorial, CMS)

@ipavlidakis ipavlidakis added the enhancement New feature or request label Oct 10, 2024
@ipavlidakis ipavlidakis self-assigned this Oct 10, 2024
@github-actions GitHub Actions
Copy link

1 Message
📖 Skipping Danger since the Pull Request is classed as Draft/Work In Progress

Generated by 🚫 Danger

@ipavlidakis ipavlidakis force-pushed the feature/manual-quality-selection branch from 02227b2 to 2cb0bfa Compare October 10, 2024 14:35
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Oct 10, 2024 •
edited
Loading

SDK Size

title develop branch diff status
StreamVideo 7.97 MB 7.99 MB +18 KB 🟢
StreamVideoSwiftUI 2.18 MB 2.18 MB 0 KB 🟢
StreamVideoUIKit 2.31 MB 2.31 MB 0 KB 🟢
StreamWebRTC 8.69 MB 8.69 MB 0 KB 🟢

@ipavlidakis ipavlidakis force-pushed the feature/manual-quality-selection branch 2 times, most recently from 836f0ff to 86d59d9 Compare October 10, 2024 14:50
@ipavlidakis ipavlidakis force-pushed the feature/manual-quality-selection branch from 86d59d9 to a5f28d3 Compare October 11, 2024 12:22
@ipavlidakis ipavlidakis marked this pull request as ready for review October 11, 2024 12:36
@ipavlidakis ipavlidakis requested a review from a team as a code owner October 11, 2024 12:36
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
112 New issues
0 Accepted issues

Measures
0 Security Hotspots
79.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

martinmitrevski
martinmitrevski approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Let's test again on the meeting and then we can merge it.

@ipavlidakis ipavlidakis merged commit 5c3bc9a into develop Oct 14, 2024
14 of 15 checks passed
@ipavlidakis ipavlidakis deleted the feature/manual-quality-selection branch October 14, 2024 08:03
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees

@ipavlidakis ipavlidakis

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ipavlidakis @Stream-SDK-Bot @martinmitrevski