Skip to content

[Feature]Disconnection timeout during call#573

Merged
ipavlidakis merged 3 commits intodevelopfrom
feature/limit-on-disconnected-state
Oct 18, 2024
Merged

[Feature]Disconnection timeout during call#573
ipavlidakis merged 3 commits intodevelopfrom
feature/limit-on-disconnected-state

Conversation

@ipavlidakis
Copy link
Contributor

@ipavlidakis ipavlidakis commented Oct 14, 2024

🎯 Goal

Provide a way to set how long a user can remain disconnected but in call (waiting to reconnect) after a network disruption.

🧪 Manual Testing Notes

  • From the login screen set the Disconnection Timeout to the desired time (in seconds)
  • Join a call
  • Disable Wifi and mobile data
  • After the set amount of time, you should be disconnected and presented with a toast regarding the error.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (Docusaurus, tutorial, CMS)

@ipavlidakis ipavlidakis added the enhancement New feature or request label Oct 14, 2024
@ipavlidakis ipavlidakis self-assigned this Oct 14, 2024
@github-actions
Copy link

github-actions bot commented Oct 14, 2024

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Oct 14, 2024

SDK Size

title develop branch diff status
StreamVideo 7.42 MB 7.43 MB +1 KB 🟢
StreamVideoSwiftUI 2.18 MB 2.18 MB 0 KB 🟢
StreamVideoUIKit 2.31 MB 2.31 MB 0 KB 🟢
StreamWebRTC 8.69 MB 8.69 MB 0 KB 🟢

@ipavlidakis ipavlidakis force-pushed the feature/limit-on-disconnected-state branch from 06b829c to a7967ed Compare October 17, 2024 19:43
@ipavlidakis ipavlidakis marked this pull request as ready for review October 17, 2024 19:43
@ipavlidakis ipavlidakis requested a review from a team as a code owner October 17, 2024 19:43
@sonarqubecloud
Copy link

Copy link
Contributor

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@ipavlidakis ipavlidakis merged commit 1fb40f1 into develop Oct 18, 2024
@ipavlidakis ipavlidakis deleted the feature/limit-on-disconnected-state branch October 18, 2024 10:46
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants