Skip to content

Fix server switching with larger render distances#2168

Closed
Camotoy wants to merge 4 commits intoGeyserMC:masterfrom
Camotoy:largerenderdistancedimfix
Closed

Fix server switching with larger render distances#2168
Camotoy wants to merge 4 commits intoGeyserMC:masterfrom
Camotoy:largerenderdistancedimfix

Conversation

@Camotoy
Copy link
Member

@Camotoy Camotoy commented Apr 23, 2021

The server only started sending its render distance during 1.14. ViaVersion compensates by sending 64 as the render distance, always - but this can choke up Bedrock in various ways. This PR fixes two separate issues related:

  • In some instances, the client would be stuck on Building Terrain during server switch. This is solved by fake-decreasing the render distance during server transfer. Zero issues have been found thus far.
  • When switching servers, chunks could be dropped. While not pretty, if the client is not spawned, they are teleported to near the chunks so they cannot be unloaded.

@jungwuk-ryu
Copy link
Contributor

May I ask when it will be merged?

@Camotoy
Copy link
Member Author

Camotoy commented May 16, 2021

I've been meaning to get some more testing going and possibly clean up the PR a bit - this feels hacky but hackiness is better than unworkable behavior.

@Camotoy Camotoy linked an issue May 22, 2021 that may be closed by this pull request
@hasankayra04
Copy link
Contributor

Is this pr going to be merged? Or is it solved by other means?

@PedroMPagani
Copy link

Is this still on the work?

@onebeastchris
Copy link
Member

Closing as stale - this would need to be re-made anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

request: client render distance value passed through to java server

6 participants