Bump/libsqlite 0.31 #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unpacking the proj source code to the cargo registry cache can run into potential data races for concurrent builds. This can be fixed by unpacking the source code into the build directory of the current build. This also ensures that we don't infer with a otherwise assumed static registry cache directory.
This commit adds an optional dependency to libsqlite3-sys to provide a bundled version of libsqlite3 as well instead of relying on a system provided version. --------- Co-authored-by: Michael Kirk <[email protected]>
The outdated Reqwest version is causing a few duplicated dependencies in our tree.
We need to always build release builds there (to prevent linker errors due to mixing up debug and release runtimes) and we need an additional flag to prevent the static library to expect some proj.dll file to exist
Addresses georust#189, reducing `cargo tree -F network | wc -l` from 296 to 190.
This commit changes proj-sys to not depend on bindgen by default as that introduces a quite heavy build time dependency (libclang) which might not be there on all systems. Instead bundled bindings for the proj version build by the `bundled_proj` feature are provided.
) I've opted to allow several different versions there instead of just bumping the supported version as that makes it much easier to use proj-sys in a complex project where other crates depend on libpsqlite3-sys as well. Cargo then will figure out the right version for all dependencies as long as there is a overlapping version.
The immediate instigation for this was georust/geo#1283. Turns out bindgen [dropped the `which` dependency](rust-lang/rust-bindgen@c03964c) a while back. But also, good to stay on top of the dependency updates.
This is a first attempt at solving georust#183 but the doctest segfaults 😕 . Does anyone have guidance here? ``` running 1 test Test executable failed (signal: 11 (SIGSEGV)). test src/proj.rs - proj::Proj::to_projjson (line 1068) ... FAILED failures: failures: src/proj.rs - proj::Proj::to_projjson (line 1068) test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 23 filtered out; finished in 0.31s ``` --------- Co-authored-by: Stephan Hügel <[email protected]>
[This is pretty widespread now](https://lib.rs/crates/thiserror/rev) (and will be more so by the next Proj release).
- [x] I agree to follow the project's [code of conduct](https://github.com/georust/.github/blob/main/CODE_OF_CONDUCT.md). - [x] I added an entry to the project's change log file if knowledge of this change could be valuable to users. - Usually called `CHANGES.md` or `CHANGELOG.md` - Prefix changelog entries for breaking changes with "BREAKING: " --- --------- Co-authored-by: Laurențiu Nicola <[email protected]>
2 tasks
weiznich
force-pushed
the
bump/libsqlite_0.31
branch
from
91abca6 to
f1dc63a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just testing the CI